Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 480663003: Converts some DCHECKs into CHECKs in hopes of helping with a crash (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Converts some DCHECKs into CHECKs in hopes of helping with a crash BUG=392974 TEST=none R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M mojo/public/cpp/bindings/lib/connector.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_impl_internal.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
sky
6 years, 4 months ago (2014-08-21 21:09:27 UTC) #1
darin (slow to review)
LGTM
6 years, 4 months ago (2014-08-21 23:47:48 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-21 23:56:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/480663003/1
6 years, 4 months ago (2014-08-21 23:59:33 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 00:55:51 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 01:02:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8297)
6 years, 4 months ago (2014-08-22 01:02:21 UTC) #7
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-22 04:16:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/480663003/1
6 years, 4 months ago (2014-08-22 04:17:25 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 05:10:20 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 05:56:18 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1293)
6 years, 4 months ago (2014-08-22 05:56:19 UTC) #12
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-22 13:59:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/480663003/1
6 years, 4 months ago (2014-08-22 14:00:16 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 14:55:01 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (1) as 291405

Powered by Google App Engine
This is Rietveld 408576698