Issue 480643002: [Telemetry] Reduce testSockOpts by 5s on mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 480643002: [Telemetry] Reduce testSockOpts by 5s on mac. (Closed)

Created:
6 years, 4 months ago by tonyg

Modified:
6 years, 4 months ago

Reviewers:
dtu

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Telemetry] Reduce testSockOpts by 5s on mac. Binding to 127.0.0.1 is instant. Binding to all interfaces takes 5s on my MBP. The part about closing the sockets is just a precaution. BUG=388256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290135

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
	M	tools/telemetry/telemetry/core/backends/chrome/websocket_unittest.py	View		1 chunk	+15 lines, -8 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dtu

https://chromiumcodereview.appspot.com/480643002/diff/1/tools/telemetry/telemetry/core/backends/chrome/websocket_unittest.py File tools/telemetry/telemetry/core/backends/chrome/websocket_unittest.py (right): https://chromiumcodereview.appspot.com/480643002/diff/1/tools/telemetry/telemetry/core/backends/chrome/websocket_unittest.py#newcode45 tools/telemetry/telemetry/core/backends/chrome/websocket_unittest.py:45: try: Alternatively: with contextlib.closing(websocket.create_connection(ws_url)) as ws: # Stuff.

6 years, 4 months ago (2014-08-16 00:41:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/480643002/1

6 years, 4 months ago (2014-08-16 00:59:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 290135

Expand Messages | Collapse Messages