Issue 480633002: sync: Fix return value in GetAllNodesForType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 480633002: sync: Fix return value in GetAllNodesForType (Closed)

Created:
6 years, 4 months ago by rlarocque

Modified:
6 years, 4 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

sync: Fix return value in GetAllNodesForType Fixes SyncManagerImpl::GetAllNodesForType's handling of a rare error case. Its callers expect it to return an empty list on failure, rather than a NULL pointer. BUG=404261 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290113