Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 480613002: [Telemetry] Speed up unittests on mac by about 10s. (Closed)

Created:
6 years, 4 months ago by tonyg
Modified:
6 years, 4 months ago
Reviewers:
baxley, dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Speed up unittests on mac by about 10s. No need to have unittests repeatedly check the USB devices. BUG=388256 TBR=baxley@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -31 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py View 2 chunks +29 lines, -31 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tonyg
6 years, 4 months ago (2014-08-15 22:02:26 UTC) #1
baxley
LGTM. Thanks, I'll rebase this to the backend CL in-flight.
6 years, 4 months ago (2014-08-15 22:17:53 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-15 22:34:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/480613002/1
6 years, 4 months ago (2014-08-15 22:36:08 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 22:36:09 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-15 22:36:10 UTC) #6
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-15 22:36:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/480613002/1
6 years, 4 months ago (2014-08-15 22:38:35 UTC) #8
dtu
lgtm
6 years, 4 months ago (2014-08-16 00:59:57 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 07:38:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (1) as 290112

Powered by Google App Engine
This is Rietveld 408576698