src/string.js - Issue 48061: Remapped regexp last-match-info to put subject and index before match indices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/string.js

Issue 48061: Remapped regexp last-match-info to put subject and index before match indices. (Closed)

Patch Set: Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/string.js

diff --git a/src/string.js b/src/string.js

index de35902d4d28d9cb11f33cf99fce19f24eac07a6..18ef3d88bde20e9e770015102230d6a449afa824 100644

--- a/src/string.js

+++ b/src/string.js

@@ -236,7 +236,7 @@ function StringReplace(search, replace) {

// needle is a string rather than a regexp. In this case we can't update

// lastMatchArray without erroneously affecting the properties on the global

// RegExp object.

-var reusableMatchInfo = [2, -1, -1, "", ""];

+var reusableMatchInfo = [2, "", "", -1, -1];

// Helper function for regular expressions in String.prototype.replace.