Issue 48061: Remapped regexp last-match-info to put subject and index before match indices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48061: Remapped regexp last-match-info to put subject and index before match indices. (Closed)

Created:
11 years, 9 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Moved subject and index before matches in RegExp lastMatchInfo. Some minor changes, and removed the new handlescope in the inner loop of replace. Only really affects replaces on extremely long strings.

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -45 lines)			Patch
M	src/heap.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/jsregexp.h	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/jsregexp.cc	View	3 chunks	+18 lines, -20 lines	0 comments	Download
M	src/macros.py	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/regexp-delay.js	View	3 chunks	+4 lines, -5 lines	1 comment	Download
M	src/string.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/v8natives.js	View	2 chunks	+1 line, -1 line	0 comments	Download
M	test/cctest/test-regexp.cc	View	1 chunk	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

11 years, 9 months ago (2009-03-17 12:39:31 UTC) #2

LGTM!

http://codereview.chromium.org/48061/diff/1/6
File src/regexp-delay.js (right):

http://codereview.chromium.org/48061/diff/1/6#newcode356
Line 356: LAST_INPUT(lastMatchInfo) = ToString(string);
This is much prettier, thanks!

Expand Messages | Collapse Messages