Cast: Reject old RTCP packets

Cast: Reject old RTCP packets

Use the RRTR ntp timestamp to make sure that any packets that is way older than the
newest packet we've seen is rejected. This is needed because we use 8-bit frame IDs,
and by doing this it should become impossible for old packets to confuse the logic
that tries to extend 8-bit frame IDs to 32-bit frame IDs.

Also clean up some logic in congestion_control that was exposed as buggy by the new test.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290667

[Alpha Left Google, 2014-08-19 18:01:36]

https://codereview.chromium.org/480563004/diff/1/media/cast/net/rtcp/rtcp.cc
File media/cast/net/rtcp/rtcp.cc (right):

https://codereview.chromium.org/480563004/diff/1/media/cast/net/rtcp/rtcp.cc#...
media/cast/net/rtcp/rtcp.cc:23: // states from crazy routers. (Based on RTRR)
nit: RRTR.

https://codereview.chromium.org/480563004/diff/1/media/cast/net/rtcp/rtcp.cc#...
media/cast/net/rtcp/rtcp.cc:128: return true;
Please add a VLOG here.

https://codereview.chromium.org/480563004/diff/1/media/cast/sender/congestion...
File media/cast/sender/congestion_control.cc (right):

https://codereview.chromium.org/480563004/diff/1/media/cast/sender/congestion...
media/cast/sender/congestion_control.cc:116: frame_stats =
GetFrameStats(last_acked_frame_ + 1);
Why this change? This isn't listed in the CL description.

[hubbe, 2014-08-19 18:27:16]

https://codereview.chromium.org/480563004/diff/1/media/cast/net/rtcp/rtcp.cc
File media/cast/net/rtcp/rtcp.cc (right):

https://codereview.chromium.org/480563004/diff/1/media/cast/net/rtcp/rtcp.cc#...
media/cast/net/rtcp/rtcp.cc:23: // states from crazy routers. (Based on RTRR)
On 2014/08/19 18:01:35, Alpha wrote:
> nit: RRTR.

Done.

https://codereview.chromium.org/480563004/diff/1/media/cast/net/rtcp/rtcp.cc#...
media/cast/net/rtcp/rtcp.cc:128: return true;
On 2014/08/19 18:01:35, Alpha wrote:
> Please add a VLOG here.

Done.

https://codereview.chromium.org/480563004/diff/1/media/cast/sender/congestion...
File media/cast/sender/congestion_control.cc (right):

https://codereview.chromium.org/480563004/diff/1/media/cast/sender/congestion...
media/cast/sender/congestion_control.cc:116: frame_stats =
GetFrameStats(last_acked_frame_ + 1);
On 2014/08/19 18:01:36, Alpha wrote:
> Why this change? This isn't listed in the CL description.

Because the test I added exposed this bug.
I'll add it to the CL description.

[Alpha Left Google, 2014-08-19 18:28:01]

The CQ bit was checked by hclam@chromium.org

[Alpha Left Google, 2014-08-19 18:28:02]

lgtm

[commit-bot: I haz the power, 2014-08-19 18:29:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hubbe@chromium.org/480563004/20001

[commit-bot: I haz the power, 2014-08-19 20:00:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-19 20:23:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-19 20:23:20]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[hubbe, 2014-08-19 21:27:22]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2014-08-19 21:27:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hubbe@chromium.org/480563004/20001

[commit-bot: I haz the power, 2014-08-19 21:29:50]

Committed patchset #2 (20001) as 290667