Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 480563003: Add gcapi to windows archives (Closed)

Created:
6 years, 4 months ago by skare_
Modified:
6 years, 3 months ago
Reviewers:
gab, kareng, kerz_chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add gcapi to windows archives BUG=407860 NOTRY=True Committed: https://crrev.com/5b91b5580950e3e39cd46930ba77c40c8081fe3c Cr-Commit-Position: refs/heads/master@{#292163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/tools/build/win/FILES.cfg View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
skare_
skare@chromium.org changed reviewers: + gab@chromium.org, kareng@google.com
6 years, 3 months ago (2014-08-26 22:44:42 UTC) #1
skare_
6 years, 3 months ago (2014-08-26 22:44:42 UTC) #2
gab
gab@chromium.org changed reviewers: + kerz@chromium.org
6 years, 3 months ago (2014-08-27 16:15:02 UTC) #3
gab
lgtm [TBR kerz in case there is something I forgot]
6 years, 3 months ago (2014-08-27 16:15:03 UTC) #4
gab
The CQ bit was checked by gab@chromium.org
6 years, 3 months ago (2014-08-27 16:15:12 UTC) #5
gab
The CQ bit was unchecked by gab@chromium.org
6 years, 3 months ago (2014-08-27 16:15:21 UTC) #6
gab
The CQ bit was checked by gab@chromium.org
6 years, 3 months ago (2014-08-27 16:15:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skare@chromium.org/480563003/1
6 years, 3 months ago (2014-08-27 16:16:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7ccc598f6a639f4bb2ad5e80acee279a87fd60db
6 years, 3 months ago (2014-08-27 16:17:03 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:52:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b91b5580950e3e39cd46930ba77c40c8081fe3c
Cr-Commit-Position: refs/heads/master@{#292163}

Powered by Google App Engine
This is Rietveld 408576698