Parse 'super' keyword.

Parse 'super' keyword.

BUG=v8:3330
LOG=N
R=arv@chromium.org, marja@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23157

[Dmitry Lomov (no reviews), 2014-08-15 19:00:46]

PTAL. Adds parsing and FLAG_harmony_classes

[arv (Not doing code reviews), 2014-08-15 19:41:07]

LGTM

https://codereview.chromium.org/480543002/diff/20001/src/ast.h
File src/ast.h (right):

https://codereview.chromium.org/480543002/diff/20001/src/ast.h#newcode2570
src/ast.h:2570: protected:
Empty line before protected.

https://codereview.chromium.org/480543002/diff/20001/src/full-codegen.h
File src/full-codegen.h (right):

https://codereview.chromium.org/480543002/diff/20001/src/full-codegen.h#newco...
src/full-codegen.h:506: 
revert?

https://codereview.chromium.org/480543002/diff/20001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/480543002/diff/20001/src/preparser.h#newcode2401
src/preparser.h:2401: if (peek() == Token::SUPER) {
You can use Check here instead.

if (Check(Token::SUPER)) {
  result = this->SuperReference(scope_, factory());
} else {
  ...

...but it seems like a lot of existing code uses peek+consume

https://codereview.chromium.org/480543002/diff/20001/src/scanner.cc
File src/scanner.cc (right):

https://codereview.chromium.org/480543002/diff/20001/src/scanner.cc#newcode910
src/scanner.cc:910: KEYWORD("class", Token::FUTURE_RESERVED_WORD)               
               \
I see your comment is not really reflecting this. Maybe just skip the comment?

https://codereview.chromium.org/480543002/diff/20001/src/scanner.h
File src/scanner.h (right):

https://codereview.chromium.org/480543002/diff/20001/src/scanner.h#newcode656
src/scanner.h:656: // Whether we scan 'super' and 'class' as keywords.
and eventually 'static'. I'll try to not forget to updated this comment.

[Dmitry Lomov (no reviews), 2014-08-15 22:11:41]

Thanks arv, comments addressed.
marja, could you take a look at parser changes as well? Thanks!

https://codereview.chromium.org/480543002/diff/20001/src/ast.h
File src/ast.h (right):

https://codereview.chromium.org/480543002/diff/20001/src/ast.h#newcode2570
src/ast.h:2570: protected:
On 2014/08/15 19:41:07, arv wrote:
> Empty line before protected.

Done.

https://codereview.chromium.org/480543002/diff/20001/src/full-codegen.h
File src/full-codegen.h (right):

https://codereview.chromium.org/480543002/diff/20001/src/full-codegen.h#newco...
src/full-codegen.h:506: 
On 2014/08/15 19:41:07, arv wrote:
> revert?

Done.

https://codereview.chromium.org/480543002/diff/20001/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/480543002/diff/20001/src/preparser.h#newcode2401
src/preparser.h:2401: if (peek() == Token::SUPER) {
On 2014/08/15 19:41:07, arv wrote:
> You can use Check here instead.
> 
> if (Check(Token::SUPER)) {
>   result = this->SuperReference(scope_, factory());
> } else {
>   ...
> 
> ...but it seems like a lot of existing code uses peek+consume

Done.

https://codereview.chromium.org/480543002/diff/20001/src/scanner.cc
File src/scanner.cc (right):

https://codereview.chromium.org/480543002/diff/20001/src/scanner.cc#newcode910
src/scanner.cc:910: KEYWORD("class", Token::FUTURE_RESERVED_WORD)               
               \
On 2014/08/15 19:41:07, arv wrote:
> I see your comment is not really reflecting this. Maybe just skip the comment?

Updated comment to reflect reality of this patch.

https://codereview.chromium.org/480543002/diff/20001/src/scanner.h
File src/scanner.h (right):

https://codereview.chromium.org/480543002/diff/20001/src/scanner.h#newcode656
src/scanner.h:656: // Whether we scan 'super' and 'class' as keywords.
On 2014/08/15 19:41:07, arv wrote:
> and eventually 'static'. I'll try to not forget to updated this comment.

Updated comment to reflect reality of this patch.

[marja, 2014-08-18 07:26:04]

parser parts lgtm

[Dmitry Lomov (no reviews), 2014-08-18 12:35:50]

Committed patchset #4 manually as 23157 (tree was closed).