Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4905)

Unified Diff: chrome/browser/supervised_user/supervised_user_service.h

Issue 480513004: Stopping the history recording for a supervised user (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/supervised_user_service.h
diff --git a/chrome/browser/supervised_user/supervised_user_service.h b/chrome/browser/supervised_user/supervised_user_service.h
index 7bbdfedefab7adc3b972c779ed10fd6ed1ed7fbe..359373c9ff05259378eea42bfd173736181fe2f1 100644
--- a/chrome/browser/supervised_user/supervised_user_service.h
+++ b/chrome/browser/supervised_user/supervised_user_service.h
@@ -187,7 +187,8 @@ class SupervisedUserService : public KeyedService,
friend class SupervisedUserServiceExtensionTestBase;
friend class SupervisedUserServiceFactory;
FRIEND_TEST_ALL_PREFIXES(SupervisedUserServiceTest, ClearOmitOnRegistration);
-
+ FRIEND_TEST_ALL_PREFIXES(SupervisedUserServiceTest,
+ ChangesSessionSyncOnChangedSettings);
// A bridge from the UI thread to the SupervisedUserURLFilters, one of which
// lives on the IO thread. This class mediates access to them and makes sure
// they are kept in sync.
@@ -272,6 +273,27 @@ class SupervisedUserService : public KeyedService,
// Returns the human readable name of the supervised user.
std::string GetSupervisedUserName() const;
+ // Gets attached to the SupervisedUserSettingsService and writes into
+ // may_session_sync_ if the history may be recorded.
+ void OnNewSettingsAvailable(const base::DictionaryValue* settings);
+
+ // Reads the state of |may_session_sync_| from given SU settings. The returned
+ // value indicates if |may_session_sync_| has changed.
+ bool FetchNewSessionSyncState(const base::DictionaryValue* settings);
+
+ // Reinitializing this Service means reloading the Sync settings. This method
+ // thereby ensures that changes in Sync settings take effect immediately.
+ void ReinitializeProfileSyncService();
Marc Treib 2014/08/19 14:00:27 Reconfigure?
+
+ // Reinitializing this Service means reloading the Sync settings. This method
+ // thereby ensures that changes in Sync settings take effect immediately.
+ bool MaySyncSessions() const;
Marc Treib 2014/08/19 14:00:28 "May" isn't the right word here, since the SU does
+
+ // The option a custodian sets to either recored or prevent recording the
+ // supervised user's history. Set by |FetchNewSessionSyncState()| and
+ // Defaults to true;
Marc Treib 2014/08/19 14:00:28 nit: don't capitalize "Defaults"; end with "."
+ bool may_session_sync_;
+
// Owns us via the KeyedService mechanism.
Profile* profile_;

Powered by Google App Engine
This is Rietveld 408576698