Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7839)

Unified Diff: chrome/test/chromedriver/js/call_function.js

Issue 480483002: [chromedriver] Add shadow DOM support to chromedriver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: "Fixed nits found in review" Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/client/webelement.py ('k') | chrome/test/chromedriver/js/focus.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/js/call_function.js
diff --git a/chrome/test/chromedriver/js/call_function.js b/chrome/test/chromedriver/js/call_function.js
index f31f95f12cb285e7d0ebfb536d39ce77a01aaacd..a9bde8d0ece1e3bb4a39a6281d5814cfd677d2a5 100644
--- a/chrome/test/chromedriver/js/call_function.js
+++ b/chrome/test/chromedriver/js/call_function.js
@@ -101,7 +101,7 @@ Cache.prototype = {
if (nodeRoot == document)
return true;
else if (SHADOW_DOM_ENABLED && nodeRoot instanceof ShadowRoot)
- return true;
+ return this.isNodeReachable_(nodeRoot.host);
return false;
}
@@ -148,7 +148,7 @@ function wrap(value) {
|| (SHADOW_DOM_ENABLED && value instanceof ShadowRoot)) {
var wrapped = {};
var root = getNodeRoot(value);
- wrapped[ELEMENT_KEY] = getPageCache(root).storeItem(value);
+ wrapped[ELEMENT_KEY] = getPageCache().storeItem(value);
return wrapped;
}
« no previous file with comments | « chrome/test/chromedriver/client/webelement.py ('k') | chrome/test/chromedriver/js/focus.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698