Issue 480473002: Drop unnecessary RadioNodeList::m_onlyMatchImgElements member

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 480473002: Drop unnecessary RadioNodeList::m_onlyMatchImgElements member (Closed)

Created:
6 years, 4 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
adamk

CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Drop unnecessary RadioNodeList::m_onlyMatchImgElements member Drop unnecessary RadioNodeList::m_onlyMatchImgElements member and replace it by an inline function that does a CollectionType comparison. The generated assembly for RadioNodeList.o is about the same size (1 line shorter). R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180374

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	Source/core/html/RadioNodeList.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/html/RadioNodeList.cpp	View		6 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/480473002/1

6 years, 4 months ago (2014-08-15 15:48:01 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 4 months ago (2014-08-15 16:34:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 180374

Expand Messages | Collapse Messages