Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 480473002: Drop unnecessary RadioNodeList::m_onlyMatchImgElements member (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
adamk
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

Drop unnecessary RadioNodeList::m_onlyMatchImgElements member Drop unnecessary RadioNodeList::m_onlyMatchImgElements member and replace it by an inline function that does a CollectionType comparison. The generated assembly for RadioNodeList.o is about the same size (1 line shorter). R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M Source/core/html/RadioNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/RadioNodeList.cpp View 6 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
6 years, 4 months ago (2014-08-15 15:12:45 UTC) #1
adamk
lgtm
6 years, 4 months ago (2014-08-15 15:28:33 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-15 15:47:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/480473002/1
6 years, 4 months ago (2014-08-15 15:48:01 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-15 16:34:52 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 17:11:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 180374

Powered by Google App Engine
This is Rietveld 408576698