Issue 480463004: Quickfix for incorrect PICTURE_MATRIX_PAINT & PATCH optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 480463004: Quickfix for incorrect PICTURE_MATRIX_PAINT & PATCH optimization. (Closed)

Created:
6 years, 4 months ago by f(malita)

Modified:
6 years, 4 months ago

Reviewers:
mtklein, robertphillips, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Quickfix for incorrect PICTURE_MATRIX_PAINT & PATCH optimization. DRAW_PICTURE_MATRIX_PAINT & DRAW_PATCH are drawing ops. R=reed@google.com,robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/8a39a6b2b1d2c75b76e0fb75aab4d51792d240f6

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/core/SkPictureRecord.cpp	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/480463004/1

6 years, 4 months ago (2014-08-19 13:44:40 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (1) as 8a39a6b2b1d2c75b76e0fb75aab4d51792d240f6

6 years, 4 months ago (2014-08-19 13:50:48 UTC) #5

mtklein

6 years, 4 months ago (2014-08-19 14:03:48 UTC) #6

Message was sent while issue was closed.

On 2014/08/19 13:50:48, I haz the power (commit-bot) wrote:
> Committed patchset #1 (1) as 8a39a6b2b1d2c75b76e0fb75aab4d51792d240f6

FYI, nothing to worry about in new-world:
  1) DrawPicture and DrawPatch are both picked up as Draw operations naturally
by the presence of their SkPaint;
  2) The parallel of this optimization is currently disabled.

1) will protect us from this problem when I eventually fix 2).

Expand Messages | Collapse Messages