Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 480413006: [SyncFS] Add idle callback to SyncFileSystemService for testing (Closed)

Created:
6 years, 4 months ago by tzik
Modified:
6 years, 4 months ago
Reviewers:
peria
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Add idle callback to SyncFileSystemService for testing * SyncFileSystemService::CallOnIdleForTesting. * Make SyncProcessRunner::OnSyncIdle invocation parallel task aware. * Make SyncProcessRunner::GetServiceState public BUG=402356 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291048

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -22 lines) Patch
M chrome/browser/sync_file_system/sync_file_system_service.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 1 2 chunks +69 lines, -12 lines 0 comments Download
M chrome/browser/sync_file_system/sync_process_runner.h View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/sync_process_runner.cc View 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tzik
PTL
6 years, 4 months ago (2014-08-21 07:08:33 UTC) #1
peria
lgtm
6 years, 4 months ago (2014-08-21 08:29:08 UTC) #2
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 4 months ago (2014-08-21 09:13:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/480413006/20001
6 years, 4 months ago (2014-08-21 09:14:18 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 10:48:32 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 11:45:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291048

Powered by Google App Engine
This is Rietveld 408576698