Move the security interstitials into a single folder

chrome/browser/resources/security_warnings/interstitial_v2.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This is the shared code for the new (Chrome 37) security interstitials. It is
 // used for both SSL interstitials and Safe Browsing interstitials.
 
 var expandedDetails = false;
+var keyPressState = 0;
+
+function $(o) {
+  return document.getElementById(o);
+}

[Dan Beam, 2014/08/19 03:06:11]

^ why is this needed?  wasn't this already defined?

if it's not anymore, why not just load util.js like this:

  <script src="chrome://resources/js/util.js"></script>

before this script is loaded in the .html file?

[felt, 2014/08/19 03:24:06]

Done.

+
+// A convenience method for sending commands to the parent page.
+function sendCommand(cmd) {
+  window.domAutomationController.setAutomationId(1);
+  window.domAutomationController.send(cmd);
+}
+
+// This allows errors to be skippped by typing "danger" into the page.
+function keyPressHandler(e) {
+  var sequence = 'danger';

[Dan Beam, 2014/08/19 03:06:11]

nit: BYPASS_SEQUENCE or something in ALL_CAPS and less generic

[felt, 2014/08/19 03:24:06]

Done.

+  if (sequence.charCodeAt(keyPressState) == e.keyCode) {
+    keyPressState++;
+    if (keyPressState == sequence.length) {
+      sendCommand(CMD_PROCEED);
+      keyPressState = 0;
+    }
+  } else {
+    keyPressState = 0;
+  }
+}
 
 function setupEvents() {
   var overridable = loadTimeData.getBoolean('overridable');
   var ssl = loadTimeData.getBoolean('ssl');
 
   if (ssl) {
     $('body').classList.add('ssl');
     $('error-code').textContent = loadTimeData.getString('errorCode');
     $('error-code').classList.remove('hidden');
   } else {
@@ skipping 44 matching lines @@
         loadTimeData.getString('closeDetails');
     if (!expandedDetails) {
       // Record a histogram entry only the first time that details is opened.
       sendCommand(ssl ? CMD_MORE : SB_CMD_EXPANDED_SEE_MORE);
       expandedDetails = true;
     }
   });
 
   preventDefaultOnPoundLinkClicks();
   setupCheckbox();
+  document.addEventListener('keypress', keyPressHandler);

[Dan Beam, 2014/08/19 03:06:11]

nit: handleKeypress or onKeypress

[felt, 2014/08/19 03:24:07]

Done.

 }
 
 document.addEventListener('DOMContentLoaded', setupEvents);