Move the security interstitials into a single folder

Move the security interstitials into a single folder

This moves the Safe Browsing and SSL interstitial HTML/JS into a single new
folder: chrome/browser/resources/security_warnings/. It also moves some
common code out of the SSL-related JS file and into the general interstitial JS
file.

BUG=402540
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291270

[felt, 2014-08-19 02:55:06]

Dan, please take a look at the latest installment of the security cleanup series

[Dan Beam, 2014-08-19 03:06:11]

https://codereview.chromium.org/480393002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/security_warnings/interstitial_v2.js (right):

https://codereview.chromium.org/480393002/diff/20001/chrome/browser/resources...
chrome/browser/resources/security_warnings/interstitial_v2.js:13: }
^ why is this needed?  wasn't this already defined?

if it's not anymore, why not just load util.js like this:

  <script src="chrome://resources/js/util.js"></script>

before this script is loaded in the .html file?

https://codereview.chromium.org/480393002/diff/20001/chrome/browser/resources...
chrome/browser/resources/security_warnings/interstitial_v2.js:23: var sequence =
'danger';
nit: BYPASS_SEQUENCE or something in ALL_CAPS and less generic

https://codereview.chromium.org/480393002/diff/20001/chrome/browser/resources...
chrome/browser/resources/security_warnings/interstitial_v2.js:98:
document.addEventListener('keypress', keyPressHandler);
nit: handleKeypress or onKeypress

[felt, 2014-08-19 03:24:07]

https://codereview.chromium.org/480393002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/security_warnings/interstitial_v2.js (right):

https://codereview.chromium.org/480393002/diff/20001/chrome/browser/resources...
chrome/browser/resources/security_warnings/interstitial_v2.js:13: }
On 2014/08/19 03:06:11, Dan Beam wrote:
> ^ why is this needed?  wasn't this already defined?
> 
> if it's not anymore, why not just load util.js like this:
> 
>   <script src="chrome://resources/js/util.js"></script>
> 
> before this script is loaded in the .html file?

Done.

https://codereview.chromium.org/480393002/diff/20001/chrome/browser/resources...
chrome/browser/resources/security_warnings/interstitial_v2.js:23: var sequence =
'danger';
On 2014/08/19 03:06:11, Dan Beam wrote:
> nit: BYPASS_SEQUENCE or something in ALL_CAPS and less generic

Done.

https://codereview.chromium.org/480393002/diff/20001/chrome/browser/resources...
chrome/browser/resources/security_warnings/interstitial_v2.js:98:
document.addEventListener('keypress', keyPressHandler);
On 2014/08/19 03:06:11, Dan Beam wrote:
> nit: handleKeypress or onKeypress

Done.

[Dan Beam, 2014-08-19 16:55:10]

lgtm

https://codereview.chromium.org/480393002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/security_warnings/interstitial_v2.js (right):

https://codereview.chromium.org/480393002/diff/40001/chrome/browser/resources...
chrome/browser/resources/security_warnings/interstitial_v2.js:11: // A
convenience method for sending commands to the parent page.
nit: // ... -> /* ...
                * @param {...} ...
                */

https://codereview.chromium.org/480393002/diff/40001/chrome/browser/resources...
chrome/browser/resources/security_warnings/interstitial_v2.js:17: // This allows
errors to be skippped by typing "danger" into the page.
same

[felt, 2014-08-19 21:04:51]

https://codereview.chromium.org/480393002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/security_warnings/interstitial_v2.js (right):

https://codereview.chromium.org/480393002/diff/40001/chrome/browser/resources...
chrome/browser/resources/security_warnings/interstitial_v2.js:11: // A
convenience method for sending commands to the parent page.
On 2014/08/19 16:55:10, Dan Beam wrote:
> nit: // ... -> /* ...
>                 * @param {...} ...
>                 */

Done.

https://codereview.chromium.org/480393002/diff/40001/chrome/browser/resources...
chrome/browser/resources/security_warnings/interstitial_v2.js:17: // This allows
errors to be skippped by typing "danger" into the page.
On 2014/08/19 16:55:10, Dan Beam wrote:
> same

Done.

[felt, 2014-08-19 21:06:36]

Can I get OWNERS reviews please?

jhawkins - c/b/browser_resources.grd
palmer - c/b/ssl/ssl_blocking_page.cc
mattm - c/b/safe_browsing/safe_browsing_blocking_page.cc

Thx.

[palmer, 2014-08-19 21:08:14]

LGTM

[mattm, 2014-08-19 21:12:57]

lgtm

[felt, 2014-08-21 13:18:35]

jhawkins - ping

[felt, 2014-08-21 17:48:25]

sky - can i have an owners review for browser_resources.grd please?

[sky, 2014-08-21 19:52:16]

.grd LGTM

[felt, 2014-08-21 20:57:43]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2014-08-21 21:06:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/felt@chromium.org/480393002/60001

[commit-bot: I haz the power, 2014-08-21 22:14:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-21 22:24:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 22:24:35]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[felt, 2014-08-21 23:42:45]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2014-08-21 23:43:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/felt@chromium.org/480393002/60001

[commit-bot: I haz the power, 2014-08-21 23:50:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[commit-bot: I haz the power, 2014-08-22 00:31:26]

Committed patchset #4 (60001) as 291270