Autocomplete should work with nameless fields

webkit/glue/editor_client_impl.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The Mac interface forwards most of these commands to the application layer,
 // and I'm not really sure what to do about most of them.
 
 #include "config.h"
 
 #include "base/compiler_specific.h"
@@ skipping 13 matching lines @@
 #include "PlatformKeyboardEvent.h"
 #include "PlatformString.h"
 #include "RenderObject.h"
 MSVC_POP_WARNING();
 
 #include "WebKit.h"
 
 #undef LOG
 #include "base/message_loop.h"
 #include "base/string_util.h"
+#include "webkit/glue/autofill_form.h"
 #include "webkit/glue/editor_client_impl.h"
 #include "webkit/glue/glue_util.h"
 #include "webkit/glue/webkit_glue.h"
 #include "webkit/glue/webview.h"
 #include "webkit/glue/webview_impl.h"
 
 // Arbitrary depth limit for the undo stack, to keep it from using
 // unbounded memory.  This is the maximum number of distinct undoable
 // actions -- unbroken stretches of typed characters are coalesced
 // into a single action.
@@ skipping 637 matching lines @@
                                 bool autofill_on_empty_value) {
   // Cancel any pending DoAutofill calls.
   autofill_factory_.RevokeAll();
 
   // Let's try to trigger autofill for that field, if applicable.
   if (!input_element->isEnabled() || !input_element->isTextField() ||
       input_element->isPasswordField() || !input_element->autoComplete()) {
     return;
   }
 
-  std::wstring name = webkit_glue::StringToStdWString(input_element->name());
+  std::wstring name = AutofillForm::GetNameForInputElement(input_element);
   if (name.empty())  // If the field has no name, then we won't have values.
     return;
 
   // Don't attempt to autofill with values that are too large.
   if (input_element->value().length() > kMaximumTextSizeForAutofill)
     return;
 
   // We post a task for doing the autofill as the caret position is not set
   // properly at this point ( http://bugs.webkit.org/show_bug.cgi?id=16976)
   // and we need it to determine whether or not to trigger autofill.
@@ skipping 27 matching lines @@
       webframe->GetPasswordListener(input_element);
   if (listener) {
     if (backspace)  // No autocomplete for password on backspace.
       return;
 
     listener->OnInlineAutocompleteNeeded(input_element, value);
     return;
   }
 
   // Then trigger form autofill.
-  std::wstring name = webkit_glue::StringToStdWString(input_element->
-      name().string());
+  std::wstring name = AutofillForm::GetNameForInputElement(input_element);
+  DCHECK_GT(static_cast<int>(name.length()), 0);
   web_view_->delegate()->QueryFormFieldAutofill(name, value,
       reinterpret_cast<int64>(input_element));
 }
 
 bool EditorClientImpl::doTextFieldCommandFromEvent(
     WebCore::Element* element,
     WebCore::KeyboardEvent* event) {
   // Remember if backspace was pressed for the autofill.  It is not clear how to
   // find if backspace was pressed from textFieldDidBeginEditing and
   // textDidChangeInTextField as when these methods are called the value of the
@@ skipping 160 matching lines @@
   }
   return L"(UNKNOWN AFFINITY)";
 }
 
 std::wstring EditorClientImpl::Describe(WebCore::CSSStyleDeclaration* style) {
   // TODO(pamg): Implement me.  It's not clear what WebKit produces for this
   // (their [style description] method), and none of the layout tests provide
   // an example.  But because none of them use it, it's not yet important.
   return std::wstring();
 }