Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 480303002: Use document from preview for System Dialog printing on Windows. (Closed)

Created:
6 years, 4 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use document from preview for System Dialog printing on Windows. System dialog shows only properties of selected printers, no system dialog with printers. Removed global Ctrl+Shift+P shortcut on windows. BUG=374321 Committed: https://crrev.com/92ab8ce04d850a59aa3d1b49ba2986845102baf3 Cr-Commit-Position: refs/heads/master@{#292032}

Patch Set 1 : Tue Aug 19 01:44:18 PDT 2014 #

Patch Set 2 : Tue 08/19/2014 11:15:54.69 #

Patch Set 3 : Tue 08/19/2014 11:17:57.84 #

Total comments: 8

Patch Set 4 : Tue Aug 19 15:57:45 PDT 2014 #

Patch Set 5 : Tue Aug 19 16:17:07 PDT 2014 #

Patch Set 6 : Tue Aug 26 01:11:31 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -476 lines) Patch
M chrome/browser/printing/print_view_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/native_layer.js View 1 2 3 3 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 1 2 3 4 5 7 chunks +47 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 3 4 5 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/common/print_messages.h View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_mock_render_thread.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/chrome_mock_render_thread.cc View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M chrome/renderer/printing/print_web_view_helper.cc View 1 2 3 4 5 1 chunk +6 lines, -1 line 0 comments Download
M printing/backend/win_helper.h View 1 chunk +8 lines, -0 lines 0 comments Download
M printing/backend/win_helper.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M printing/print_job_constants.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M printing/print_job_constants.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M printing/printing_context.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context.cc View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
M printing/printing_context_android.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_android.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M printing/printing_context_linux.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_linux.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M printing/printing_context_mac.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_mac.mm View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M printing/printing_context_no_system_dialog.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_no_system_dialog.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M printing/printing_context_win.h View 1 2 3 4 5 2 chunks +8 lines, -28 lines 0 comments Download
M printing/printing_context_win.cc View 1 2 3 4 5 9 chunks +61 lines, -279 lines 0 comments Download
M printing/printing_context_win_unittest.cc View 1 2 3 4 5 3 chunks +1 line, -145 lines 0 comments Download

Messages

Total messages: 36 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-08-19 21:50:22 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-08-19 21:51:15 UTC) #2
Noam Samuel
lgtm plus nits https://codereview.chromium.org/480303002/diff/140001/chrome/browser/printing/print_job_worker.h File chrome/browser/printing/print_job_worker.h (right): https://codereview.chromium.org/480303002/diff/140001/chrome/browser/printing/print_job_worker.h#newcode55 chrome/browser/printing/print_job_worker.h:55: // Set the new print settings. ...
6 years, 4 months ago (2014-08-20 00:04:17 UTC) #3
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/480303002/diff/140001/chrome/browser/printing/print_job_worker.h File chrome/browser/printing/print_job_worker.h (right): https://codereview.chromium.org/480303002/diff/140001/chrome/browser/printing/print_job_worker.h#newcode55 chrome/browser/printing/print_job_worker.h:55: // Set the new print settings. This function takes ...
6 years, 4 months ago (2014-08-20 02:42:55 UTC) #4
Vitaly Buka (NO REVIEWS)
Patchset #1 (id:1) has been deleted
6 years, 4 months ago (2014-08-26 08:12:31 UTC) #5
Vitaly Buka (NO REVIEWS)
Patchset #5 (id:100001) has been deleted
6 years, 4 months ago (2014-08-26 08:12:43 UTC) #6
Vitaly Buka (NO REVIEWS)
Patchset #1 (id:20001) has been deleted
6 years, 4 months ago (2014-08-26 08:12:53 UTC) #7
Vitaly Buka (NO REVIEWS)
Patchset #1 (id:40001) has been deleted
6 years, 4 months ago (2014-08-26 08:13:04 UTC) #8
Vitaly Buka (NO REVIEWS)
Patchset #2 (id:80001) has been deleted
6 years, 4 months ago (2014-08-26 08:13:20 UTC) #9
Vitaly Buka (NO REVIEWS)
Patchset #15 (id:380001) has been deleted
6 years, 4 months ago (2014-08-26 08:13:49 UTC) #10
Vitaly Buka (NO REVIEWS)
Patchset #14 (id:360001) has been deleted
6 years, 4 months ago (2014-08-26 08:13:58 UTC) #11
Vitaly Buka (NO REVIEWS)
Patchset #10 (id:280001) has been deleted
6 years, 4 months ago (2014-08-26 08:14:07 UTC) #12
Vitaly Buka (NO REVIEWS)
Patchset #8 (id:240001) has been deleted
6 years, 4 months ago (2014-08-26 08:14:17 UTC) #13
Vitaly Buka (NO REVIEWS)
Patchset #7 (id:220001) has been deleted
6 years, 4 months ago (2014-08-26 08:14:26 UTC) #14
Vitaly Buka (NO REVIEWS)
Patchset #8 (id:300001) has been deleted
6 years, 4 months ago (2014-08-26 08:14:35 UTC) #15
Vitaly Buka (NO REVIEWS)
Patchset #7 (id:260001) has been deleted
6 years, 4 months ago (2014-08-26 08:14:43 UTC) #16
Vitaly Buka (NO REVIEWS)
Patchset #7 (id:320001) has been deleted
6 years, 4 months ago (2014-08-26 08:14:53 UTC) #17
Vitaly Buka (NO REVIEWS)
Patchset #6 (id:200001) has been deleted
6 years, 4 months ago (2014-08-26 08:15:03 UTC) #18
Vitaly Buka (NO REVIEWS)
Patchset #6 (id:340001) has been deleted
6 years, 4 months ago (2014-08-26 08:15:28 UTC) #19
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + jschuh%chromium.org@gtempaccount.com
6 years, 4 months ago (2014-08-26 08:31:00 UTC) #20
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-08-26 08:31:00 UTC) #21
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + jschuh@chromium.org - jschuh%chromium.org@gtempaccount.com
6 years, 4 months ago (2014-08-26 08:32:55 UTC) #22
Vitaly Buka (NO REVIEWS)
+jschuh for https://codereview.chromium.org/480303002/diff/240002/chrome/common/print_messages.h
6 years, 4 months ago (2014-08-26 08:32:55 UTC) #23
Vitaly Buka (NO REVIEWS)
Patchset #7 (id:410001) has been deleted
6 years, 4 months ago (2014-08-26 09:04:54 UTC) #24
jschuh
Must have missed this one. lgtm for ipc security.
6 years, 3 months ago (2014-08-26 12:26:37 UTC) #25
Vitaly Buka (NO REVIEWS)
On 2014/08/26 12:26:37, Justin Schuh wrote: > Must have missed this one. lgtm for ipc ...
6 years, 3 months ago (2014-08-26 17:40:36 UTC) #26
Aleksey Shlyapnikov
lgtm
6 years, 3 months ago (2014-08-26 17:51:35 UTC) #27
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + thestig@chromium.org
6 years, 3 months ago (2014-08-26 19:07:54 UTC) #28
Vitaly Buka (NO REVIEWS)
+thestig for chrome/renderer/chrome_mock_render_thread.*
6 years, 3 months ago (2014-08-26 19:07:54 UTC) #29
Lei Zhang
lgtm
6 years, 3 months ago (2014-08-26 20:54:47 UTC) #30
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-26 21:13:47 UTC) #31
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-26 21:14:28 UTC) #32
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 3 months ago (2014-08-26 21:16:24 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/480303002/240002
6 years, 3 months ago (2014-08-26 21:17:44 UTC) #34
commit-bot: I haz the power
Committed patchset #6 (240002) as 94c408aba9a5a4692c800a278c49acceda37805c
6 years, 3 months ago (2014-08-26 23:42:09 UTC) #35
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:47:24 UTC) #36
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/92ab8ce04d850a59aa3d1b49ba2986845102baf3
Cr-Commit-Position: refs/heads/master@{#292032}

Powered by Google App Engine
This is Rietveld 408576698