Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: athena/wm/window_manager_impl.cc

Issue 480293003: Adding functions to the window_list_provider for accessing the activities window list (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: athena/wm/window_manager_impl.cc
diff --git a/athena/wm/window_manager_impl.cc b/athena/wm/window_manager_impl.cc
index c7b4b9523140dc977d1d0538be2a2de04377bbe8..9797422ecba0da460f1de66b1ac7a9956fba91dc 100644
--- a/athena/wm/window_manager_impl.cc
+++ b/athena/wm/window_manager_impl.cc
@@ -184,11 +184,8 @@ void WindowManagerImpl::SetInOverview(bool active) {
if (active) {
FOR_EACH_OBSERVER(WindowManagerObserver, observers_, OnOverviewModeEnter());
- // Re-stack all windows in the order defined by window_list_provider_.
- aura::Window::Windows window_list = window_list_provider_->GetWindowList();
- aura::Window::Windows::iterator it;
- for (it = window_list.begin(); it != window_list.end(); ++it)
- container_->StackChildAtTop(*it);
+ // Note: The window_list_provider_ resembles the exact window list of the
+ // container, so no re-stacking is required before showing the OverviewMode.
overview_ = WindowOverviewMode::Create(
container_.get(), window_list_provider_.get(),
split_view_controller_.get(), this);
@@ -221,6 +218,10 @@ void WindowManagerImpl::ToggleSplitViewForTest() {
ToggleSplitview();
}
+WindowListProvider* WindowManagerImpl::GetWindowListProvider() {
+ return window_list_provider_.get();
+}
+
void WindowManagerImpl::OnSelectWindow(aura::Window* window) {
if (split_view_controller_->IsSplitViewModeActive()) {
split_view_controller_->DeactivateSplitMode();

Powered by Google App Engine
This is Rietveld 408576698