athena/wm/split_view_controller_unittest.cc - Issue 480293003: Adding functions to the window_list_provider for accessing the activities window list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/wm/split_view_controller_unittest.cc

Issue 480293003: Adding functions to the window_list_provider for accessing the activities window list (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moved Window observer from ResourceManager to WindowListProvider Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« athena/wm/public/window_list_provider_observer.h ('K') | « athena/wm/split_view_controller.cc ('k') | athena/wm/window_list_provider_impl.h » ('j') | athena/wm/window_list_provider_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: athena/wm/split_view_controller_unittest.cc

diff --git a/athena/wm/split_view_controller_unittest.cc b/athena/wm/split_view_controller_unittest.cc

index 6bde13b5f66817c2df9e98a98cda9e3c5507bfda..a407a94f0ff85686536a9baef5ced4f32ec6c693 100644

--- a/athena/wm/split_view_controller_unittest.cc

+++ b/athena/wm/split_view_controller_unittest.cc

@@ -82,18 +82,18 @@ TEST_F(SplitViewControllerTest, SplitModeActivation) {

controller->ActivateSplitMode(NULL, windows[0]);

EXPECT_EQ(windows[kNumWindows - 1], controller->left_window());

EXPECT_EQ(windows[0], controller->right_window());

- EXPECT_EQ(windows[0], *list_provider->GetWindowList().rbegin());

+ EXPECT_EQ(windows[0], *list_provider->GetCurrentWindowList().rbegin());

controller->ActivateSplitMode(windows[1], NULL);

EXPECT_EQ(windows[1], controller->left_window());

EXPECT_EQ(windows[0], controller->right_window());

- EXPECT_EQ(windows[1], *list_provider->GetWindowList().rbegin());

+ EXPECT_EQ(windows[1], *list_provider->GetCurrentWindowList().rbegin());

controller->ActivateSplitMode(windows[4], windows[5]);

EXPECT_EQ(windows[4], controller->left_window());

EXPECT_EQ(windows[5], controller->right_window());

- EXPECT_EQ(windows[4], *list_provider->GetWindowList().rbegin());

- EXPECT_EQ(windows[5], *(list_provider->GetWindowList().rbegin() + 1));

+ EXPECT_EQ(windows[4], *list_provider->GetCurrentWindowList().rbegin());

+ EXPECT_EQ(windows[5], *(list_provider->GetCurrentWindowList().rbegin() + 1));

}

TEST_F(SplitViewControllerTest, LandscapeOnly) {