Issue 480293002: rebaseline_server: constrain setADir/setBDir to consistently refer to single directories, not lists

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 480293002: rebaseline_server: constrain setADir/setBDir to consistently refer to single directories, not lists (Closed)

Created:
6 years, 4 months ago by epoger

Modified:
6 years, 4 months ago

Reviewers:
stephana

CC:
reviews_skia.org, rmistry

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

rebaseline_server: constrain setADir/setBDir to consistently refer to single directories, not lists Before this CL, we supported multiple setADirs/setBDirs for some operations but not others... now we consistently support a single pair of directories. NOTRY=true TBR=stephana Committed: https://skia.googlesource.com/skia/+/caa80b9a46ea00a7b582d96d73302939aa21b5ee

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -47 lines)			Patch
M	gm/rebaseline_server/compare_rendered_pictures.py	View	4 chunks	+20 lines, -32 lines	0 comments	Download
M	gm/rebaseline_server/compare_rendered_pictures_test.py	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	gm/rebaseline_server/server.py	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_repo_url/compare_rendered_pictures.json	View	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/480293002/1

6 years, 4 months ago (2014-08-18 22:14:40 UTC) #3

commit-bot: I haz the power

6 years, 4 months ago (2014-08-18 22:14:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as caa80b9a46ea00a7b582d96d73302939aa21b5ee

Expand Messages | Collapse Messages