Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: src/lookup.cc

Issue 480283003: Minor LookupIterator cleanups (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/lookup.h ('k') | src/objects.h » ('j') | src/objects.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.cc
diff --git a/src/lookup.cc b/src/lookup.cc
index 56001c3e171ceb8366ff7c3631473bbd01e2d218..58e3032e502d2e2fbfed4d7ac855dff500b86e28 100644
--- a/src/lookup.cc
+++ b/src/lookup.cc
@@ -35,8 +35,8 @@ void LookupIterator::Next() {
// Either was found in the receiver, or the receiver has no prototype.
if (holder == NULL) return;
- maybe_holder_ = handle(holder);
- holder_map_ = handle(map);
+ maybe_holder_ = handle(holder, isolate_);
+ holder_map_ = handle(map, isolate_);
}
@@ -53,7 +53,7 @@ Handle<JSReceiver> LookupIterator::GetRoot() const {
Handle<Map> LookupIterator::GetReceiverMap() const {
Handle<Object> receiver = GetReceiver();
if (receiver->IsNumber()) return isolate_->factory()->heap_number_map();
- return handle(Handle<HeapObject>::cast(receiver)->map());
+ return handle(Handle<HeapObject>::cast(receiver)->map(), isolate_);
}
@@ -184,7 +184,7 @@ void LookupIterator::PrepareTransitionToDataProperty(
}
transition_map_ = Map::TransitionToDataProperty(
- handle(receiver->map()), name_, value, attributes, store_mode);
+ handle(receiver->map(), isolate_), name_, value, attributes, store_mode);
state_ = TRANSITION;
}
@@ -209,8 +209,9 @@ void LookupIterator::TransitionToAccessorProperty(
// observable.
Handle<JSObject> receiver = GetStoreTarget();
maybe_holder_ = receiver;
- holder_map_ = Map::TransitionToAccessorProperty(
- handle(receiver->map()), name_, component, accessor, attributes);
+ holder_map_ =
+ Map::TransitionToAccessorProperty(handle(receiver->map(), isolate_),
+ name_, component, accessor, attributes);
JSObject::MigrateToMap(receiver, holder_map_);
ReloadPropertyInformation();
@@ -243,7 +244,7 @@ void LookupIterator::TransitionToAccessorProperty(
JSObject::SetNormalizedProperty(receiver, name_, pair, details);
JSObject::ReoptimizeIfPrototype(receiver);
- holder_map_ = handle(receiver->map());
+ holder_map_ = handle(receiver->map(), isolate_);
ReloadPropertyInformation();
}
« no previous file with comments | « src/lookup.h ('k') | src/objects.h » ('j') | src/objects.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698