Issue 480283003: Minor LookupIterator cleanups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 480283003: Minor LookupIterator cleanups (Closed)

Created:
6 years, 3 months ago by Toon Verwaest

Modified:
6 years, 3 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Minor LookupIterator cleanups BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23348

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -42 lines)			Patch
M	src/ic/ic.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/lookup.h	View	3 chunks	+2 lines, -14 lines	0 comments	Download
M	src/lookup.cc	View	5 chunks	+8 lines, -7 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+0 lines, -3 lines	1 comment	Download
M	src/objects.cc	View	2 chunks	+6 lines, -13 lines	0 comments	Download
M	src/runtime.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

LGTM https://codereview.chromium.org/480283003/diff/1/src/objects.h File src/objects.h (left): https://codereview.chromium.org/480283003/diff/1/src/objects.h#oldcode7801 src/objects.h:7801: PropertyCell* GetPropertyCell(LookupResult* result); Thanks for removing this method!

6 years, 3 months ago (2014-08-25 10:24:27 UTC) #2

Toon Verwaest

6 years, 3 months ago (2014-08-25 11:31:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 23348 (presubmit successful).

Expand Messages | Collapse Messages