Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6368)

Unified Diff: chrome/renderer/resources/extensions/extension_options_events.js

Issue 480243003: Implement smoother autosizing of the extension options overlay (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/extension_options_events.js
diff --git a/chrome/renderer/resources/extensions/extension_options_events.js b/chrome/renderer/resources/extensions/extension_options_events.js
index c842b08ed62b9b1780c5d97550454bfdf1c8791a..6938bc42ce089c75c1e2c1ac62214e70caf4c69a 100644
--- a/chrome/renderer/resources/extensions/extension_options_events.js
+++ b/chrome/renderer/resources/extensions/extension_options_events.js
@@ -16,10 +16,10 @@ var EXTENSION_OPTIONS_EVENTS = {
},
'sizechanged': {
evt: CreateEvent('extensionOptionsInternal.onSizeChanged'),
- customHandler: function(handler, event, webViewEvent) {
- handler.handleSizeChangedEvent(event, webViewEvent);
+ customHandler: function(handler, event, extensionOptionsEvent) {
+ handler.handleSizeChangedEvent(event, extensionOptionsEvent);
},
- fields:['width', 'height']
+ fields:['newWidth', 'newHeight', 'oldWidth', 'oldHeight']
}
}
@@ -63,8 +63,10 @@ ExtensionOptionsEvents.prototype.setupEvent = function(name, info) {
ExtensionOptionsEvents.prototype.handleSizeChangedEvent = function(
event, extensionOptionsEvent) {
- this.extensionOptionsInternal.onSizeChanged(extensionOptionsEvent.width,
- extensionOptionsEvent.height);
+ this.extensionOptionsInternal.onSizeChanged(extensionOptionsEvent.newWidth,
+ extensionOptionsEvent.newHeight,
+ extensionOptionsEvent.oldWidth,
+ extensionOptionsEvent.oldHeight);
this.extensionOptionsInternal.dispatchEvent(extensionOptionsEvent);
}

Powered by Google App Engine
This is Rietveld 408576698