chrome/browser/guest_view/extension_options/extension_options_guest.cc - Issue 480243003: Implement smoother autosizing of the extension options overlay

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/extension_options/extension_options_guest.cc

Issue 480243003: Implement smoother autosizing of the extension options overlay (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/extension_options/extension_options_constants.cc ('k') | chrome/browser/resources/extensions/extension_options_overlay.css » ('j') | chrome/browser/resources/extensions/extension_options_overlay.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/extension_options/extension_options_guest.cc

diff --git a/chrome/browser/guest_view/extension_options/extension_options_guest.cc b/chrome/browser/guest_view/extension_options/extension_options_guest.cc

index f7ca2908f72de01663b09ff9edfdecbc4ea2d6c1..1e0522bcdc07d9555fddc42a6e8530d9bebfcba7 100644

--- a/chrome/browser/guest_view/extension_options/extension_options_guest.cc

+++ b/chrome/browser/guest_view/extension_options/extension_options_guest.cc

@@ -144,8 +144,10 @@ void ExtensionOptionsGuest::GuestSizeChangedDueToAutoSize(

const gfx::Size& old_size,

const gfx::Size& new_size) {

scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());

- args->SetInteger(extensionoptions::kWidth, new_size.width());

- args->SetInteger(extensionoptions::kHeight, new_size.height());

+ args->SetInteger(extensionoptions::kNewWidth, new_size.width());

+ args->SetInteger(extensionoptions::kNewHeight, new_size.height());

+ args->SetInteger(extensionoptions::kOldWidth, old_size.width());

+ args->SetInteger(extensionoptions::kOldHeight, old_size.height());

DispatchEventToEmbedder(new extensions::GuestViewBase::Event(

extension_options_internal::OnSizeChanged::kEventName, args.Pass()));

}