content/renderer/media/rtc_peer_connection_handler.cc - Issue 480233007: Remove implicit conversions from scoped_refptr to T* in content/renderer/media/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_peer_connection_handler.cc

Issue 480233007: Remove implicit conversions from scoped_refptr to T* in content/renderer/media/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/renderer_gpu_video_accelerator_factories.cc ('k') | content/renderer/media/rtc_video_decoder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/rtc_peer_connection_handler.cc

diff --git a/content/renderer/media/rtc_peer_connection_handler.cc b/content/renderer/media/rtc_peer_connection_handler.cc

index 93e8a76a7a994408e0268ef87d0c264259a912a5..f8493d0f7d93f8015b041b8e605bd799e1796a53 100644

--- a/content/renderer/media/rtc_peer_connection_handler.cc

+++ b/content/renderer/media/rtc_peer_connection_handler.cc

@@ -714,15 +714,15 @@ void RTCPeerConnectionHandler::removeStream(

break;

}

- DCHECK(webrtc_stream);

- native_peer_connection_->RemoveStream(webrtc_stream);

+ DCHECK(webrtc_stream.get());

+ native_peer_connection_->RemoveStream(webrtc_stream.get());

if (peer_connection_tracker_)

peer_connection_tracker_->TrackRemoveStream(

this, stream, PeerConnectionTracker::SOURCE_LOCAL);

PerSessionWebRTCAPIMetrics::GetInstance()->DecrementStreamCounter();

track_metrics_.RemoveStream(MediaStreamTrackMetrics::SENT_STREAM,

- webrtc_stream);

+ webrtc_stream.get());

}

void RTCPeerConnectionHandler::getStats(