Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: pkg/analysis_server/lib/src/edit/edit_domain.dart

Issue 480223002: Test for 'edit.getAssists'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/constants.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/edit/edit_domain.dart
diff --git a/pkg/analysis_server/lib/src/edit/edit_domain.dart b/pkg/analysis_server/lib/src/edit/edit_domain.dart
index f65beb09bd8d582cdbe9bbf0ceaee870e3cd9da3..26635f85f516912dd7c005aec9b25dc64e1c705f 100644
--- a/pkg/analysis_server/lib/src/edit/edit_domain.dart
+++ b/pkg/analysis_server/lib/src/edit/edit_domain.dart
@@ -10,7 +10,10 @@ import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/edit/fix.dart';
import 'package:analysis_server/src/protocol.dart';
import 'package:analysis_server/src/services/constants.dart';
+import 'package:analysis_server/src/services/correction/assist.dart';
+import 'package:analysis_server/src/services/correction/change.dart';
import 'package:analysis_server/src/services/correction/fix.dart';
+import 'package:analysis_server/src/services/json.dart';
import 'package:analysis_server/src/services/refactoring/refactoring.dart';
import 'package:analysis_server/src/services/search/search_engine.dart';
import 'package:analyzer/src/generated/ast.dart';
@@ -42,17 +45,22 @@ class EditDomainHandler implements RequestHandler {
}
Response getAssists(Request request) {
- // file
- RequestDatum fileDatum = request.getRequiredParameter(FILE);
- String file = fileDatum.asString();
- // offset
- RequestDatum offsetDatum = request.getRequiredParameter(OFFSET);
- int offset = offsetDatum.asInt();
- // length
- RequestDatum lengthDatum = request.getRequiredParameter(LENGTH);
- int length = lengthDatum.asInt();
- // TODO(brianwilkerson) implement
- return null;
+ String file = request.getRequiredParameter(FILE).asString();
+ int offset = request.getRequiredParameter(OFFSET).asInt();
+ int length = request.getRequiredParameter(LENGTH).asInt();
+ List<Change> changes = <Change>[];
+ List<CompilationUnit> units = server.getResolvedCompilationUnits(file);
+ if (units.isNotEmpty) {
+ CompilationUnit unit = units[0];
+ List<Assist> assists = computeAssists(searchEngine, unit, offset, length);
+ assists.forEach((Assist assist) {
+ changes.add(assist.change);
+ });
+ }
+ // respond
+ Response response = new Response(request.id);
+ response.setResult(ASSISTS, objectToJson(changes));
+ return response;
}
Response getAvailableRefactorings(Request request) {
@@ -89,7 +97,7 @@ class EditDomainHandler implements RequestHandler {
ErrorFixes errorFixes = new ErrorFixes(serverError);
errorFixesList.add(errorFixes);
fixes.forEach((fix) {
- return errorFixes.addFix(fix);
+ errorFixes.addFix(fix);
});
}
}
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/constants.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698