Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 480113002: Fix srcAlpaWillBeOne() for coverage drawing (Closed)

Created:
6 years, 4 months ago by bsalomon
Modified:
6 years, 4 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix srcAlpaWillBeOne() for coverage drawing Committed: https://skia.googlesource.com/skia/+/637e57e3beca3a2b488b16997d428406bb6f655f

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use 4 byte coverage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M src/gpu/GrDrawState.cpp View 1 1 chunk +21 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
6 years, 4 months ago (2014-08-18 16:43:50 UTC) #1
egdaniel
lgtm + question on getCoverage() https://codereview.chromium.org/480113002/diff/1/src/gpu/GrDrawState.cpp File src/gpu/GrDrawState.cpp (right): https://codereview.chromium.org/480113002/diff/1/src/gpu/GrDrawState.cpp#newcode408 src/gpu/GrDrawState.cpp:408: coverage = this->getCoverage(); should ...
6 years, 4 months ago (2014-08-18 16:50:11 UTC) #2
bsalomon
On 2014/08/18 at 16:50:11, egdaniel wrote: > lgtm + question on getCoverage() > > https://codereview.chromium.org/480113002/diff/1/src/gpu/GrDrawState.cpp ...
6 years, 4 months ago (2014-08-18 16:56:36 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-08-18 18:42:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/480113002/20001
6 years, 4 months ago (2014-08-18 18:42:56 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 18:49:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 637e57e3beca3a2b488b16997d428406bb6f655f

Powered by Google App Engine
This is Rietveld 408576698