Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 480003002: Start timeline recording using TimelinePanel methods instead of agent methods (Closed)

Created:
6 years, 4 months ago by yurys
Modified:
6 years, 4 months ago
Reviewers:
caseq, alph, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Start timeline recording using TimelinePanel methods instead of agent methods We are going to switch to tracing backend for the timeline and there won't be TimelineAgent so the tests are changed to use higher level abstractions. BUG=398785 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180438

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M LayoutTests/http/tests/inspector/timeline-test.js View 1 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yurys
6 years, 4 months ago (2014-08-18 07:52:05 UTC) #1
caseq
lgtm
6 years, 4 months ago (2014-08-18 07:55:59 UTC) #2
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 4 months ago (2014-08-18 07:57:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/480003002/20001
6 years, 4 months ago (2014-08-18 07:57:52 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-18 09:03:04 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 09:45:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180438

Powered by Google App Engine
This is Rietveld 408576698