Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 479993002: [Android] Shell Action Bar behavior same as chrome

Created:
6 years, 4 months ago by AviD
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, AKVT
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Shell Action Bar behavior same as chrome Added styles to Chrome Shell and Content Shell, so that the behavior of Action Bar in shell apks are same as Chrome Browser. In Chrome Browser, the Action Bar overlaps the URL Bar but in Shell apks, the Action Bar pushes the Activity Window downwards to make space for the Action Bar BUG=404534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/android/shell/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/shell/res/values-v17/styles.xml View 1 chunk +3 lines, -1 line 0 comments Download
M content/shell/android/shell_apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/android/shell_apk/res/values-v17/styles.xml View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
AviD
Could you PTAL?
6 years, 4 months ago (2014-08-18 07:52:24 UTC) #1
Yaron
yfriedman->nyquist
6 years, 4 months ago (2014-08-18 15:58:35 UTC) #2
Ted C
On 2014/08/18 15:58:35, Yaron wrote: > yfriedman->nyquist What happens if you attempt to long press ...
6 years, 4 months ago (2014-08-19 00:55:28 UTC) #3
AviD
6 years, 4 months ago (2014-08-20 07:44:07 UTC) #4
> What happens if you attempt to long press on the text in the url bar
> with this change?  Does the action bar overlap it?
> 
> If I recall, we had to do special magic when copying from the URL bar
> with a change similar to this in Chrome, and I wouldn't want to add
> that kind of cruft to these test shells if it does.

Yes, Action Bar overlaps the url bar when we long press on url bar.

Currently, android does not allow changing of styles dynamically.
Otherwise, we could have changed the "android:windowActionModeOverlay" property
programatically to false when we show the Action Bar in
SelectActionModeCallback,
and set it to true when it is destroyed. This could have been one way of
bringing in the same behavior of Action Bar as Chrome.

Do you have any suggestions regarding this?

Powered by Google App Engine
This is Rietveld 408576698