Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 479933003: Move NativeAppWindow to extensions (Closed)

Created:
6 years, 4 months ago by hashimoto
Modified:
6 years, 4 months ago
Reviewers:
benwells, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, Ilya Sherman, sadrul, nkostylev+watch_chromium.org, estade+watch_chromium.org, benquan, tfarina, dyu1, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, rouslan+autofillwatch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Dane Wallinga
Project:
chromium
Visibility:
Public.

Description

Move NativeAppWindow to extensions Move native_app_window.h from apps/ui to extensions/browser/app_window. Change the namespace from apps to extensions. Add dependency on components/web_modal to extensions/browser. BUG=403726 TBR=sky@chromium.org for include fix under chrome/browser Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290786

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -182 lines) Patch
M apps/app_shim/app_shim_interactive_uitest_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
M apps/app_shim/extension_app_shim_handler_mac.cc View 2 chunks +1 line, -1 line 0 comments Download
M apps/app_window.h View 1 5 chunks +5 lines, -4 lines 0 comments Download
M apps/app_window.cc View 1 3 chunks +2 lines, -1 line 0 comments Download
M apps/app_window_browsertest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M apps/app_window_contents.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M apps/app_window_contents.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M apps/app_window_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/app_window_registry.cc View 2 chunks +1 line, -1 line 0 comments Download
M apps/apps.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M apps/ui/apps_client.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
D apps/ui/native_app_window.h View 1 chunk +0 lines, -99 lines 0 comments Download
M apps/ui/views/app_window_frame_view.h View 1 4 chunks +6 lines, -4 lines 0 comments Download
M apps/ui/views/app_window_frame_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M apps/ui/views/native_app_window_views.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/apps/app_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_browsertest_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_window_interactive_uitest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/apps/web_view_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/ash_panel_contents.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/ash_panel_contents.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/apps/chrome_apps_client.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/apps/chrome_apps_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/accelerator_commands_browsertest.cc View 1 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/multi_profile_app_window_launcher_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/chrome_apps_client_cocoa.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/chrome_apps_client_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/chrome_apps_client_views_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/glass_app_window_frame_view_win.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/apps/glass_app_window_frame_view_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 2 chunks +1 line, -1 line 0 comments Download
M extensions/browser/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + extensions/browser/app_window/native_app_window.h View 1 3 chunks +15 lines, -7 lines 0 comments Download
M extensions/extensions.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
hashimoto
6 years, 4 months ago (2014-08-19 10:50:33 UTC) #1
benwells
nice, great progress! lgtm
6 years, 4 months ago (2014-08-20 05:14:13 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-20 06:35:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/479933003/40001
6 years, 4 months ago (2014-08-20 06:36:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 07:36:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 07:41:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/5433)
6 years, 4 months ago (2014-08-20 07:41:06 UTC) #7
hashimoto
TBRing sky@chromium.org for include fix under chrome/browser
6 years, 4 months ago (2014-08-20 07:43:03 UTC) #8
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-20 07:43:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/479933003/40001
6 years, 4 months ago (2014-08-20 07:43:18 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 07:48:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (40001) as 290786

Powered by Google App Engine
This is Rietveld 408576698