Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 479803002: Made code conform to blink's coding guidelines and improved performance (Closed)

Created:
6 years, 4 months ago by Klemen Forstnerič
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Made code in DocumentMarkerController.cpp conform to blink's coding guidelines and improved performance in WebViewImpl.cpp a bit. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M Source/core/dom/DocumentMarkerController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Klemen Forstnerič
Rouslan: PTAL Patch Set 1.
6 years, 4 months ago (2014-08-16 15:46:18 UTC) #1
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 4 months ago (2014-08-16 19:48:41 UTC) #2
please use gerrit instead
lgtm
6 years, 4 months ago (2014-08-16 19:48:41 UTC) #3
please use gerrit instead
The CQ bit was unchecked by rouslan@chromium.org
6 years, 4 months ago (2014-08-16 19:48:52 UTC) #4
please use gerrit instead
You still need a review from an owner.
6 years, 4 months ago (2014-08-16 19:49:09 UTC) #5
Klemen Forstnerič
tkent, OWNER PTAL Patch Set 1.
6 years, 4 months ago (2014-08-16 21:55:22 UTC) #6
tkent
> Made code conform to blink's coding guidelines and improved performance > a bit. The ...
6 years, 4 months ago (2014-08-18 01:24:40 UTC) #7
Klemen Forstnerič
On 2014/08/18 01:24:40, tkent wrote: > > Made code conform to blink's coding guidelines and ...
6 years, 4 months ago (2014-08-18 09:31:35 UTC) #8
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-18 09:43:32 UTC) #9
tkent
lgtm
6 years, 4 months ago (2014-08-18 09:43:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klemen.forstneric@gmail.com/479803002/1
6 years, 4 months ago (2014-08-18 09:44:44 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-18 10:49:20 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 11:28:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (1) as 180447

Powered by Google App Engine
This is Rietveld 408576698