Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 479793004: [turbofan] Initial import of SimplifiedOperatorReducer. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Initial import of SimplifiedOperatorReducer. TEST=compiler-unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23289

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : WIP #

Patch Set 4 : WIP #

Patch Set 5 : WIP #

Patch Set 6 : WIP #

Patch Set 7 : Mac Fix #

Patch Set 8 : REBASE #

Total comments: 2

Patch Set 9 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+773 lines, -23 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/graph-reducer.h View 3 chunks +10 lines, -3 lines 0 comments Download
M src/compiler/node-matchers.h View 2 chunks +13 lines, -0 lines 0 comments Download
A src/compiler/simplified-operator-reducer.h View 1 2 3 4 5 1 chunk +55 lines, -0 lines 0 comments Download
A src/compiler/simplified-operator-reducer.cc View 1 2 3 4 5 6 7 1 chunk +135 lines, -0 lines 0 comments Download
M src/unique.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/compiler-unittests/change-lowering-unittest.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M test/compiler-unittests/compiler-unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/compiler-unittests/graph-unittest.h View 1 2 3 4 3 chunks +15 lines, -3 lines 0 comments Download
M test/compiler-unittests/graph-unittest.cc View 1 2 3 4 2 chunks +54 lines, -0 lines 0 comments Download
M test/compiler-unittests/machine-operator-reducer-unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
A test/compiler-unittests/simplified-operator-reducer-unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +481 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
PTAL
6 years, 4 months ago (2014-08-21 12:03:24 UTC) #1
Jarin
lgtm, great work. You might want to update BUILD.gn before committing. https://codereview.chromium.org/479793004/diff/140001/test/compiler-unittests/simplified-operator-reducer-unittest.cc File test/compiler-unittests/simplified-operator-reducer-unittest.cc (right): ...
6 years, 4 months ago (2014-08-21 20:11:24 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/479793004/diff/140001/test/compiler-unittests/simplified-operator-reducer-unittest.cc File test/compiler-unittests/simplified-operator-reducer-unittest.cc (right): https://codereview.chromium.org/479793004/diff/140001/test/compiler-unittests/simplified-operator-reducer-unittest.cc#newcode134 test/compiler-unittests/simplified-operator-reducer-unittest.cc:134: // BooleanNot(true) => false Done. Refactored those tests.
6 years, 4 months ago (2014-08-22 04:44:32 UTC) #3
Benedikt Meurer
6 years, 4 months ago (2014-08-22 04:48:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #9 manually as 23289 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698