Fix midnight determination

Fix midnight determination

Midnight determination by scaling value of internal base::Time representation doesn't take in account time zones, it counts as UTC, but other time logic in local time.
There is failure of test ChromeNetworkDailyDataSavingMetricsTest.PartialDayTimeChange if system time zone will overcome test time to another day (like our +4 for example).
This fix make it work fine and in same way for win and others operating systems.


R=bolian@chromium.org

BUG=

Committed: https://crrev.com/a6f3247f1ba66550946190f7f81b7039631e4f37
Cr-Commit-Position: refs/heads/master@{#292589}

[Boris Yusupov, 2014-08-16 12:56:28]

Hi! Could you review my changes please?

[Boris Yusupov, 2014-08-25 14:14:34]

The CQ bit was checked by boriay@yandex-team.ru

[commit-bot: I haz the power, 2014-08-25 14:14:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/boriay@yandex-team.ru/479793002/1

[commit-bot: I haz the power, 2014-08-25 14:14:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-25 14:14:49]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bolian, 2014-08-25 19:26:24]

bolian@chromium.org changed reviewers:
+ bengr@chromium.org
- bolian@chromium.org

[bengr, 2014-08-25 21:37:09]

https://codereview.chromium.org/479793002/diff/1/components/data_reduction_pr...
File components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc
(right):

https://codereview.chromium.org/479793002/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc:403: if
(then_internal != 0) {
nit: We shouldn't use or assume anything about the internal representation of
time. So perhaps do:

base::Time then_midnight = 
    base::Time::FromInternalValue(then_internal);
if (then_midnight != base::Time())
  then_midnight = then_midnight.LocalMidnight();

[Boris Yusupov, 2014-08-27 10:59:27]

I removed internal time representation usage. Can you look again?

[bengr, 2014-08-28 21:46:41]

On 2014/08/27 10:59:27, Boris Yusupov wrote:
> I removed internal time representation usage. Can you look again?

lgtm

[Boris Yusupov, 2014-08-29 07:06:29]

The CQ bit was checked by boriay@yandex-team.ru

[commit-bot: I haz the power, 2014-08-29 07:07:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/boriay@yandex-team.ru/479793002/20001

[commit-bot: I haz the power, 2014-08-29 08:05:03]

Committed patchset #2 (id:20001) as a3eb10e323352d47c905659ac9b92dd0b355323d

[commit-bot: I haz the power, 2014-09-10 03:06:56]

Patchset 2 (id:??) landed as
https://crrev.com/a6f3247f1ba66550946190f7f81b7039631e4f37
Cr-Commit-Position: refs/heads/master@{#292589}