Source/core/xml/XMLTreeViewer.idl - Issue 479753003: Transform XML tree viewer to blink-in-js implementation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/xml/XMLTreeViewer.idl

Issue 479753003: Transform XML tree viewer to blink-in-js implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4

5 [	4 [

6 RuntimeEnabled=Geofencing,

7 NoInterfaceObject,

8 GarbageCollected,	5 GarbageCollected,

9 ] interface GeofencingRegion {	6 ] interface XMLTreeViewer {

10 readonly attribute DOMString id;	7 [ImplementedInPrivateScript, OnlyExposedToPrivateScript] void transformDocum entToTreeView();
	eseidel 2014/08/26 05:40:54 What's the point of moving this to Blink-in-JS if What's the point of moving this to Blink-in-JS if we have to add backdoors to implement it? vivekg 2014/08/26 05:51:57 Sorry @eseidel, I could not get what meant by sayi Show quoted text On 2014/08/26 at 05:40:54, eseidel wrote: > What's the point of moving this to Blink-in-JS if we have to add backdoors to implement it? Sorry @eseidel, I could not get what meant by saying 'add backdoors to implement it?'. haraken 2014/08/26 05:57:48 I'm considering a way to avoid the backdoor (but a Show quoted text On 2014/08/26 05:40:54, eseidel wrote: > What's the point of moving this to Blink-in-JS if we have to add backdoors to > implement it? I'm considering a way to avoid the backdoor (but at least this CL is not making our current situation worse; i.e., the current XMLTreeViewer is already implemented in JS and working by manually getting invoked from C++). Either way I think we should move this method to Document.idl (or to DocumentXMLTreeViewer.idl, which is a partial interface of Document.idl). That way we no longer need an interface for XMLTreeViewer. Then you can completely remove the XMLTreeViewer class.
11 };	8 };

OLD	NEW

« Source/core/xml/XMLTreeViewer.h ('K') | « Source/core/xml/XMLTreeViewer.cpp ('k') | Source/core/xml/XMLTreeViewer.js » ('j') | no next file with comments »