Ensure syncer::internal::GetComputerName returns a UTF-8 string.

Ensure syncer::internal::GetComputerName returns a UTF-8 string.

Prior to this change, on Windows, GetComputerName resulted in a call to
GetComputerNameA, which returns an ANSI string (not ASCII, not UTF-8).
Call GetComputerNameW instead and convert the returned wide string to
UTF-8.

Tested by adding U+00AB to the computer name.  Saw in about:sync the
name contained a U+FFFD instead (symbol for unrepresentable character).
Performed sync dashboard clear, applied patch, saw that the name
correctly contained U+00AB.

This CL does not address corrupted device info that's already in the
field.  Depending on impact that may be addressed in a future CL.

BUG=406470
Committed: https://crrev.com/58cfacd2313c2a67aa52e02f1eccc352df427502
Cr-Commit-Position: refs/heads/master@{#292466}

[maniscalco, 2014-08-28 17:23:00]

maniscalco@chromium.org changed reviewers:
+ zea@chromium.org

[maniscalco, 2014-08-28 17:23:58]

Nicolas, would you please review this change?

[Nicolas Zea, 2014-08-28 18:58:29]

lgtm

https://codereview.chromium.org/479703004/diff/40001/sync/util/get_session_na...
File sync/util/get_session_name_win.cc (right):

https://codereview.chromium.org/479703004/diff/40001/sync/util/get_session_na...
sync/util/get_session_name_win.cc:7: #include "base/logging.h"
nit: can remove this?

[maniscalco, 2014-08-28 19:10:59]

Thanks for the speedy review.

https://codereview.chromium.org/479703004/diff/40001/sync/util/get_session_na...
File sync/util/get_session_name_win.cc (right):

https://codereview.chromium.org/479703004/diff/40001/sync/util/get_session_na...
sync/util/get_session_name_win.cc:7: #include "base/logging.h"
On 2014/08/28 18:58:29, Nicolas Zea wrote:
> nit: can remove this?

We need it since it's where DCHECK comes from.

[maniscalco, 2014-08-28 20:12:50]

The CQ bit was checked by maniscalco@chromium.org

[commit-bot: I haz the power, 2014-08-28 20:13:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/maniscalco@chromium.org/479703004/40001

[commit-bot: I haz the power, 2014-08-28 20:53:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[commit-bot: I haz the power, 2014-08-28 21:38:57]

Committed patchset #3 (id:40001) as 91f7e9e15dd013ba94515d8c5d48ca15ecff1b7a

[commit-bot: I haz the power, 2014-09-10 03:02:23]

Patchset 3 (id:??) landed as
https://crrev.com/58cfacd2313c2a67aa52e02f1eccc352df427502
Cr-Commit-Position: refs/heads/master@{#292466}