Add finalize sweeping event to GCIdleTimeHandler.

Add finalize sweeping event to GCIdleTimeHandler.

BUG=
R=ulan@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23302

[ulan, 2014-08-22 07:51:58]

lgtm

https://codereview.chromium.org/479693004/diff/40001/src/heap/gc-idle-time-ha...
File src/heap/gc-idle-time-handler.cc (left):

https://codereview.chromium.org/479693004/diff/40001/src/heap/gc-idle-time-ha...
src/heap/gc-idle-time-handler.cc:13: const size_t
GCIdleTimeHandler::kMaxMarkCompactTimeInMs = 1000000;
Do heap-unit-tests link without this line? I've been getting link errors before.

[ulan, 2014-08-22 08:05:35]

https://codereview.chromium.org/479693004/diff/40001/src/heap/gc-idle-time-ha...
File src/heap/gc-idle-time-handler.cc (right):

https://codereview.chromium.org/479693004/diff/40001/src/heap/gc-idle-time-ha...
src/heap/gc-idle-time-handler.cc:75: if (heap_state.sweeping_in_progress &&
On the second thought, this check should be outside the  "if
(!heap_state.can_start_incremental_marking)" branch.

Otherwise, we wait for sweepers only if it is not worth activating incremental
marking.

https://codereview.chromium.org/479693004/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/479693004/diff/40001/src/heap/heap.cc#newcode...
src/heap/heap.cc:4296: heap_state.incremental_marking_stopped =
incremental_marking()->IsStopped();
incremental_marking has SWEEPING state, should we also check for this state when
deciding to DO_FINALIZE_SWEEPING?

[Hannes Payer (out of office), 2014-08-22 09:57:04]

https://codereview.chromium.org/479693004/diff/40001/src/heap/gc-idle-time-ha...
File src/heap/gc-idle-time-handler.cc (right):

https://codereview.chromium.org/479693004/diff/40001/src/heap/gc-idle-time-ha...
src/heap/gc-idle-time-handler.cc:75: if (heap_state.sweeping_in_progress &&
On 2014/08/22 08:05:35, ulan wrote:
> On the second thought, this check should be outside the  "if
> (!heap_state.can_start_incremental_marking)" branch.
> 
> Otherwise, we wait for sweepers only if it is not worth activating incremental
> marking.

Done.

https://codereview.chromium.org/479693004/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/479693004/diff/40001/src/heap/heap.cc#newcode...
src/heap/heap.cc:4296: heap_state.incremental_marking_stopped =
incremental_marking()->IsStopped();
On 2014/08/22 08:05:35, ulan wrote:
> incremental_marking has SWEEPING state, should we also check for this state
when
> deciding to DO_FINALIZE_SWEEPING?

The SWEEPING state in incremental marking is just set when we are about to start
incremental marking, but are blocked by the sweeper threads. Hence, it does not
really fit the condition.

[Hannes Payer (out of office), 2014-08-22 11:14:25]

Committed patchset #5 manually as 23302 (presubmit successful).