Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 479673003: Remove the acclerated overflow scroll and fixed root background flags. (Closed)

Created:
6 years, 4 months ago by danakj
Modified:
6 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews, creis+watch_chromium.org, nkostylev+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, abarth-chromium, Ian Vollick
Project:
chromium
Visibility:
Public.

Description

Remove the acclerated overflow scroll and fixed root background flags. These flags are merged into --{dis,en}able-prefer-compositing-to-lcd-text which controls these along with fixed position. Depends on https://codereview.chromium.org/479653003/. R=piman@chromium.org, aelias BUG=365851 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -86 lines) Patch
M chrome/browser/about_flags.cc View 3 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/android/content_startup_flags.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M content/renderer/render_view_impl.cc View 4 chunks +7 lines, -31 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
danakj
6 years, 4 months ago (2014-08-15 22:12:08 UTC) #1
danakj
This still sets all the Blink settings independently but derives them all from a common ...
6 years, 4 months ago (2014-08-15 22:13:35 UTC) #2
piman
lgtm
6 years, 4 months ago (2014-08-15 22:30:40 UTC) #3
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-17 01:40:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/479673003/20001
6 years, 4 months ago (2014-08-17 01:41:59 UTC) #5
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 4 months ago (2014-08-17 01:43:19 UTC) #6
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-17 20:44:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/479673003/1
6 years, 4 months ago (2014-08-17 20:44:44 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-17 22:16:01 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-17 22:20:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/6764)
6 years, 4 months ago (2014-08-17 22:20:34 UTC) #11
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-18 06:45:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/479673003/1
6 years, 4 months ago (2014-08-18 06:46:49 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (1) as 290218
6 years, 4 months ago (2014-08-18 07:37:16 UTC) #14
Mike West
A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/485663002/ by mkwst@chromium.org. The ...
6 years, 4 months ago (2014-08-18 10:52:54 UTC) #15
danakj
On 2014/08/18 10:52:54, Mike West wrote: > A revert of this CL (patchset #1) has ...
6 years, 4 months ago (2014-08-18 15:25:17 UTC) #16
danakj
On 2014/08/18 15:25:17, danakj wrote: > On 2014/08/18 10:52:54, Mike West wrote: > > A ...
6 years, 4 months ago (2014-08-18 15:26:06 UTC) #17
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-18 21:20:01 UTC) #18
danakj
Blink bots seem good, will reland.
6 years, 4 months ago (2014-08-18 21:20:13 UTC) #19
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 4 months ago (2014-08-18 21:20:16 UTC) #20
danakj
6 years, 4 months ago (2014-08-18 21:22:01 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 manually as 290364 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698