Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 479633002: Remove several unneeded modules from webkitpy.common. (Closed)

Created:
6 years, 4 months ago by Dirk Pranke
Modified:
6 years, 4 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Remove several unneeded modules from webkitpy.common. webkitpy.common.editdistance, webkitpy.common.lru_cache, and webkitpy.common.thread were no longer being used. webkitpy.common.newstringio could be (and should've been) replaced by io.StringIO() or io.BytesIO() as appropriate to indicate if you were dealing with text or bytes. R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180397

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -655 lines) Patch
M Tools/Scripts/webkitpy/common/checksvnconfigfile.py View 1 chunk +0 lines, -1 line 0 comments Download
D Tools/Scripts/webkitpy/common/editdistance.py View 1 chunk +0 lines, -47 lines 0 comments Download
D Tools/Scripts/webkitpy/common/editdistance_unittest.py View 1 chunk +0 lines, -43 lines 0 comments Download
D Tools/Scripts/webkitpy/common/lru_cache.py View 1 chunk +0 lines, -134 lines 0 comments Download
D Tools/Scripts/webkitpy/common/lru_cache_unittest.py View 1 chunk +0 lines, -93 lines 0 comments Download
D Tools/Scripts/webkitpy/common/newstringio.py View 1 chunk +0 lines, -39 lines 0 comments Download
D Tools/Scripts/webkitpy/common/newstringio_unittest.py View 1 chunk +0 lines, -40 lines 0 comments Download
D Tools/Scripts/webkitpy/common/thread/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
D Tools/Scripts/webkitpy/common/thread/messagepump.py View 1 chunk +0 lines, -59 lines 0 comments Download
D Tools/Scripts/webkitpy/common/thread/messagepump_unittest.py View 1 chunk +0 lines, -83 lines 0 comments Download
D Tools/Scripts/webkitpy/common/thread/threadedmessagequeue.py View 1 chunk +0 lines, -52 lines 0 comments Download
D Tools/Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py View 1 chunk +0 lines, -53 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py View 3 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Dirk Pranke
6 years, 4 months ago (2014-08-15 18:14:07 UTC) #1
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-15 18:17:25 UTC) #2
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 4 months ago (2014-08-15 20:35:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/479633002/1
6 years, 4 months ago (2014-08-15 20:36:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-15 21:34:43 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 22:18:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22998)
6 years, 4 months ago (2014-08-15 22:18:30 UTC) #7
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 4 months ago (2014-08-15 22:23:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/479633002/1
6 years, 4 months ago (2014-08-15 22:23:41 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-15 23:32:14 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 00:11:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (1) as 180397

Powered by Google App Engine
This is Rietveld 408576698