Fix incorrect paths.

Fix incorrect paths.


BUG=none
R= binji@chromium.org, jfb@chromium.org
TEST=none
NOTRY=true
(documentation only change)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291005

[JF, 2014-08-15 21:17:08]

Looks good overall, but I'll let Ben signoff since this isn't documentation I've
touched before.

https://codereview.chromium.org/479623002/diff/1/native_client_sdk/doc_genera...
File native_client_sdk/doc_generated/_static/pygments.css (left):

https://codereview.chromium.org/479623002/diff/1/native_client_sdk/doc_genera...
native_client_sdk/doc_generated/_static/pygments.css:20: .highlight .gt { color:
#0044DD } /* Generic.Traceback */
Same here, you should checkout the original file.

https://codereview.chromium.org/479623002/diff/1/native_client_sdk/src/doc/de...
File native_client_sdk/src/doc/devguide/devcycle/building.rst (right):

https://codereview.chromium.org/479623002/diff/1/native_client_sdk/src/doc/de...
native_client_sdk/src/doc/devguide/devcycle/building.rst:44: script is located
in the ``pepper_<version>/tools/``, meaning under your
in the ... directory

https://codereview.chromium.org/479623002/diff/1/native_client_sdk/src/doc/de...
native_client_sdk/src/doc/devguide/devcycle/building.rst:91:
``pepper_<version>/toolchain/<OS_platform>_<architecture>_<library>``.
Replace "library" with "c_library" since the definition isn't there.

https://codereview.chromium.org/479623002/diff/1/native_client_sdk/src/doc/de...
native_client_sdk/src/doc/devguide/devcycle/building.rst:551: * ARM toolchain:
``toolchain/<platform>_arm_<library>/arm-nacl/lib``
Same here on c_library?

[binji, 2014-08-15 21:34:17]

I see why you made this change, though we have a specific definition of
NACL_SDK_ROOT that is different than yours:

NACL_SDK_ROOT is used in all of the SDK code to mean the directory that contains
examples, toolchain, tools, etc. That is, it is the directory named "pepper_35"
or "pepper_canary".

So when we reference NACL_SDK_ROOT in the documentation, we should be consistent
with this.

I personally think that adding pepper_<version> to all of these locations makes
it harder to read. Is there a way we can be more clear without having to update
all the paths?

[jpmedley, 2014-08-18 14:58:23]

PTAL

https://codereview.chromium.org/479623002/diff/1/native_client_sdk/doc_genera...
File native_client_sdk/doc_generated/_static/pygments.css (left):

https://codereview.chromium.org/479623002/diff/1/native_client_sdk/doc_genera...
native_client_sdk/doc_generated/_static/pygments.css:20: .highlight .gt { color:
#0044DD } /* Generic.Traceback */
I think that whatever earlier comment you're referring to got lost.

On 2014/08/15 21:17:08, JF wrote:
> Same here, you should checkout the original file.

https://codereview.chromium.org/479623002/diff/1/native_client_sdk/src/doc/de...
File native_client_sdk/src/doc/devguide/devcycle/building.rst (right):

https://codereview.chromium.org/479623002/diff/1/native_client_sdk/src/doc/de...
native_client_sdk/src/doc/devguide/devcycle/building.rst:44: script is located
in the ``pepper_<version>/tools/``, meaning under your
On 2014/08/15 21:17:08, JF wrote:
> in the ... directory

Done.

https://codereview.chromium.org/479623002/diff/1/native_client_sdk/src/doc/de...
native_client_sdk/src/doc/devguide/devcycle/building.rst:91:
``pepper_<version>/toolchain/<OS_platform>_<architecture>_<library>``.
On 2014/08/15 21:17:08, JF wrote:
> Replace "library" with "c_library" since the definition isn't there.

Done.

https://codereview.chromium.org/479623002/diff/1/native_client_sdk/src/doc/de...
native_client_sdk/src/doc/devguide/devcycle/building.rst:551: * ARM toolchain:
``toolchain/<platform>_arm_<library>/arm-nacl/lib``
On 2014/08/15 21:17:08, JF wrote:
> Same here on c_library?

Done. Also did lines 559 and 560, below.

[binji, 2014-08-20 21:11:57]

great, lgtm

[binji, 2014-08-20 21:13:12]

https://codereview.chromium.org/479623002/diff/80001/native_client_sdk/doc_ge...
File native_client_sdk/doc_generated/community/index.html (right):

https://codereview.chromium.org/479623002/diff/80001/native_client_sdk/doc_ge...
native_client_sdk/doc_generated/community/index.html:6:
<strong>implementors</strong> (contributors to the <a class="reference external"
href="nacl_project_">open-source Native Client project</a>) and
<strong>developers</strong>, who use Native Client to develop web
revert this again, please. If this continues to be an issue, perhaps we should
use a normal link for this (instead of using nacl_project_)

[jpmedley, 2014-08-21 01:49:36]

The CQ bit was checked by jmedley@chromium.org

[jpmedley, 2014-08-21 01:49:51]

The CQ bit was unchecked by jmedley@chromium.org

[jpmedley, 2014-08-21 01:49:55]

The CQ bit was checked by jmedley@chromium.org

[commit-bot: I haz the power, 2014-08-21 01:50:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jmedley@chromium.org/479623002/100001

[commit-bot: I haz the power, 2014-08-21 02:39:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[commit-bot: I haz the power, 2014-08-21 03:08:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 03:08:19]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[JF, 2014-08-21 03:14:51]

The CQ bit was checked by jfb@chromium.org

[JF, 2014-08-21 03:15:17]

Same comment here as on the other issue: I added NOTRY=true since it's a
documentation only change.

[commit-bot: I haz the power, 2014-08-21 03:15:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jmedley@chromium.org/479623002/100001

[commit-bot: I haz the power, 2014-08-21 04:47:56]

Committed patchset #6 (100001) as 291005