Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 479623002: Fix incorrect paths. (Closed)

Created:
6 years, 4 months ago by jpmedley
Modified:
6 years, 4 months ago
Reviewers:
binji1, JF, binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect paths. BUG=none R= binji@chromium.org, jfb@chromium.org TEST=none NOTRY=true (documentation only change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291005

Patch Set 1 #

Total comments: 8

Patch Set 2 : Response to comments. #

Patch Set 3 : Fix more paths. #

Patch Set 4 : Forgot to run make chromesite. #

Patch Set 5 : Forgot pyments.css again. #

Total comments: 1

Patch Set 6 : Revert community/index.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -146 lines) Patch
M native_client_sdk/doc_generated/devguide/devcycle/building.html View 1 2 3 14 chunks +54 lines, -72 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/running.html View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/building.rst View 1 2 19 chunks +53 lines, -70 lines 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/running.rst View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
JF
Looks good overall, but I'll let Ben signoff since this isn't documentation I've touched before. ...
6 years, 4 months ago (2014-08-15 21:17:08 UTC) #1
binji
I see why you made this change, though we have a specific definition of NACL_SDK_ROOT ...
6 years, 4 months ago (2014-08-15 21:34:17 UTC) #2
jpmedley
PTAL https://codereview.chromium.org/479623002/diff/1/native_client_sdk/doc_generated/_static/pygments.css File native_client_sdk/doc_generated/_static/pygments.css (left): https://codereview.chromium.org/479623002/diff/1/native_client_sdk/doc_generated/_static/pygments.css#oldcode20 native_client_sdk/doc_generated/_static/pygments.css:20: .highlight .gt { color: #0044DD } /* Generic.Traceback ...
6 years, 4 months ago (2014-08-18 14:58:23 UTC) #3
binji
great, lgtm
6 years, 4 months ago (2014-08-20 21:11:57 UTC) #4
binji
https://codereview.chromium.org/479623002/diff/80001/native_client_sdk/doc_generated/community/index.html File native_client_sdk/doc_generated/community/index.html (right): https://codereview.chromium.org/479623002/diff/80001/native_client_sdk/doc_generated/community/index.html#newcode6 native_client_sdk/doc_generated/community/index.html:6: <strong>implementors</strong> (contributors to the <a class="reference external" href="nacl_project_">open-source Native ...
6 years, 4 months ago (2014-08-20 21:13:12 UTC) #5
jpmedley
The CQ bit was checked by jmedley@chromium.org
6 years, 4 months ago (2014-08-21 01:49:36 UTC) #6
jpmedley
The CQ bit was unchecked by jmedley@chromium.org
6 years, 4 months ago (2014-08-21 01:49:51 UTC) #7
jpmedley
The CQ bit was checked by jmedley@chromium.org
6 years, 4 months ago (2014-08-21 01:49:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jmedley@chromium.org/479623002/100001
6 years, 4 months ago (2014-08-21 01:50:34 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 02:39:50 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 03:08:18 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/7827)
6 years, 4 months ago (2014-08-21 03:08:19 UTC) #12
JF
The CQ bit was checked by jfb@chromium.org
6 years, 4 months ago (2014-08-21 03:14:51 UTC) #13
JF
Same comment here as on the other issue: I added NOTRY=true since it's a documentation ...
6 years, 4 months ago (2014-08-21 03:15:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jmedley@chromium.org/479623002/100001
6 years, 4 months ago (2014-08-21 03:15:27 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 04:47:56 UTC) #16
Message was sent while issue was closed.
Committed patchset #6 (100001) as 291005

Powered by Google App Engine
This is Rietveld 408576698