Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1458)

Unified Diff: tools/tests/render_pictures_test.py

Issue 479613002: Add ability to output ImageBaseGSUrl to render_picture and use in rebaseline server (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fix render_pictures_test after rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/render_pictures_main.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/tests/render_pictures_test.py
diff --git a/tools/tests/render_pictures_test.py b/tools/tests/render_pictures_test.py
index 9ff322696819b922d4ffa8e1781ee460fe757281..6daadd8b08b46aaa95ca17af396c94f83d1ceb8e 100755
--- a/tools/tests/render_pictures_test.py
+++ b/tools/tests/render_pictures_test.py
@@ -197,6 +197,7 @@ class RenderPicturesTest(base_unittest.TestCase):
'--writeWholeImage'])
expected_summary_dict = {
"header" : EXPECTED_HEADER_CONTENTS,
+ "image-base-gs-url" : None,
"descriptions" : None,
"actual-results" : {
"red.skp": {
@@ -233,6 +234,7 @@ class RenderPicturesTest(base_unittest.TestCase):
modified_red_tiles[5]['comparisonResult'] = 'failure-ignored'
expected_summary_dict = {
"header" : EXPECTED_HEADER_CONTENTS,
+ "image-base-gs-url" : None,
"descriptions" : None,
"actual-results" : {
"red.skp": {
@@ -270,6 +272,7 @@ class RenderPicturesTest(base_unittest.TestCase):
modified_red_tiles[5]['comparisonResult'] = 'no-comparison'
expected_summary_dict = {
"header" : EXPECTED_HEADER_CONTENTS,
+ "image-base-gs-url" : None,
"descriptions" : None,
"actual-results" : {
"red.skp": {
@@ -315,6 +318,7 @@ class RenderPicturesTest(base_unittest.TestCase):
if expected_summary_dict == None:
expected_summary_dict = {
"header" : EXPECTED_HEADER_CONTENTS,
+ "image-base-gs-url" : None,
"descriptions" : None,
"actual-results" : {
"red.skp": {
@@ -340,6 +344,7 @@ class RenderPicturesTest(base_unittest.TestCase):
pass
expected_summary_dict = {
"header" : EXPECTED_HEADER_CONTENTS,
+ "image-base-gs-url" : None,
"descriptions" : None,
"actual-results" : {
"red.skp": {
@@ -370,6 +375,7 @@ class RenderPicturesTest(base_unittest.TestCase):
])
expected_summary_dict = {
"header" : EXPECTED_HEADER_CONTENTS,
+ "image-base-gs-url" : None,
"descriptions" : {
"builder": "builderName",
"renderMode": "renderModeName",
@@ -421,6 +427,7 @@ class RenderPicturesTest(base_unittest.TestCase):
'--writeJsonSummaryPath', output_json_path])
expected_summary_dict = {
"header" : EXPECTED_HEADER_CONTENTS,
+ "image-base-gs-url" : None,
"descriptions" : None,
"actual-results" : {
"red.skp": {
@@ -449,6 +456,7 @@ class RenderPicturesTest(base_unittest.TestCase):
'--writeJsonSummaryPath', output_json_path])
expected_summary_dict = {
"header" : EXPECTED_HEADER_CONTENTS,
+ "image-base-gs-url" : None,
"descriptions" : None,
"actual-results" : {
"red.skp": {
@@ -484,6 +492,7 @@ class RenderPicturesTest(base_unittest.TestCase):
'--writeJsonSummaryPath', output_json_path])
expected_summary_dict = {
"header" : EXPECTED_HEADER_CONTENTS,
+ "image-base-gs-url" : None,
"descriptions" : None,
"actual-results" : {
"red.skp": {
@@ -515,6 +524,7 @@ class RenderPicturesTest(base_unittest.TestCase):
'--writeJsonSummaryPath', output_json_path])
expected_summary_dict = {
"header" : EXPECTED_HEADER_CONTENTS,
+ "image-base-gs-url" : None,
"descriptions" : None,
"actual-results" : {
"red.skp": {
« no previous file with comments | « tools/render_pictures_main.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698