gm/rebaseline_server/compare_to_expectations.py - Issue 479613002: Add ability to output ImageBaseGSUrl to render_picture and use in rebaseline server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/rebaseline_server/compare_to_expectations.py

Issue 479613002: Add ability to output ImageBaseGSUrl to render_picture and use in rebaseline server (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix render_pictures_test after rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/rebaseline_server/compare_to_expectations.py

diff --git a/gm/rebaseline_server/compare_to_expectations.py b/gm/rebaseline_server/compare_to_expectations.py

index a93d9b9fdf1628a4335cea5fb0a27ec8ba8d56f1..303294c0ae9a7470329f49ac73b3d793f7ee659a 100755

--- a/gm/rebaseline_server/compare_to_expectations.py

+++ b/gm/rebaseline_server/compare_to_expectations.py

@@ -347,7 +347,8 @@ class ExpectationComparisons(results.BaseComparisons):

try:

image_pair = imagepair.ImagePair(

image_diff_db=self._image_diff_db,

- base_url=gm_json.GM_ACTUALS_ROOT_HTTP_URL,

+ imageA_base_url=gm_json.GM_ACTUALS_ROOT_HTTP_URL,

+ imageB_base_url=gm_json.GM_ACTUALS_ROOT_HTTP_URL,

imageA_relative_url=expected_image_relative_url,

imageB_relative_url=actual_image_relative_url,

expectations=expectations_dict,

« no previous file with comments | « gm/rebaseline_server/compare_rendered_pictures_test.py ('k') | gm/rebaseline_server/imagepair.py » ('j') | no next file with comments »