Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: tools/image_expectations.h

Issue 479613002: Add ability to output ImageBaseGSUrl to render_picture and use in rebaseline server (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fix render_pictures_test after rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2014 Google Inc. 2 * Copyright 2014 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef image_expectations_DEFINED 8 #ifndef image_expectations_DEFINED
9 #define image_expectations_DEFINED 9 #define image_expectations_DEFINED
10 10
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 178
179 /** 179 /**
180 * Adds a key/value pair to the descriptions dict within the summary of results. 180 * Adds a key/value pair to the descriptions dict within the summary of results.
181 * 181 *
182 * @param key key within the descriptions dict 182 * @param key key within the descriptions dict
183 * @param value value to associate with that key 183 * @param value value to associate with that key
184 */ 184 */
185 void addDescription(const char *key, const char *value); 185 void addDescription(const char *key, const char *value);
186 186
187 /** 187 /**
188 * Adds the image base Google Storage URL to the summary of results.
189 *
190 * @param imageBaseGSUrl the image base Google Storage URL
191 */
192 void setImageBaseGSUrl(const char *imageBaseGSUrl);
193
194 /**
188 * Returns the Expectation for this test. 195 * Returns the Expectation for this test.
189 * 196 *
190 * @param sourceName name of the source file that generated this result 197 * @param sourceName name of the source file that generated this result
191 * @param tileNumber if not NULL, pointer to tile number 198 * @param tileNumber if not NULL, pointer to tile number
192 * 199 *
193 * TODO(stephana): To make this work for GMs, we will need to add parame ters for 200 * TODO(stephana): To make this work for GMs, we will need to add parame ters for
194 * config, and maybe renderMode/builder? 201 * config, and maybe renderMode/builder?
195 */ 202 */
196 Expectation getExpectation(const char *sourceName, const int *tileNumber =NULL); 203 Expectation getExpectation(const char *sourceName, const int *tileNumber =NULL);
197 204
(...skipping 12 matching lines...) Expand all
210 * It is up to the caller to close filePtr after this is done. 217 * It is up to the caller to close filePtr after this is done.
211 * 218 *
212 * Returns true if successful. 219 * Returns true if successful.
213 */ 220 */
214 static bool Parse(SkFILE* filePtr, Json::Value *jsonRoot); 221 static bool Parse(SkFILE* filePtr, Json::Value *jsonRoot);
215 222
216 Json::Value fActualResults; 223 Json::Value fActualResults;
217 Json::Value fDescriptions; 224 Json::Value fDescriptions;
218 Json::Value fExpectedJsonRoot; 225 Json::Value fExpectedJsonRoot;
219 Json::Value fExpectedResults; 226 Json::Value fExpectedResults;
227 Json::Value fImageBaseGSUrl;
220 }; 228 };
221 229
222 } // namespace sk_tools 230 } // namespace sk_tools
223 231
224 #endif // image_expectations_DEFINED 232 #endif // image_expectations_DEFINED
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698