Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 479573002: Added a method to check if adding a shortcut to the homescreen is supported. (Closed)

Created:
6 years, 4 months ago by whywhat
Modified:
6 years, 4 months ago
Reviewers:
Ted C, gone
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Added a method to check if adding a shortcut to the homescreen is supported. The method usage is added here: https://chrome-internal-review.googlesource.com/172629 BUG=403891 NOTRY=true NOTREECHECKS=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java View 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
whywhat
PTaL
6 years, 4 months ago (2014-08-15 15:52:16 UTC) #1
gone
lgtm
6 years, 4 months ago (2014-08-15 18:00:29 UTC) #2
whywhat
+Ted for OWNERS LGTM :)
6 years, 4 months ago (2014-08-15 18:15:50 UTC) #3
Ted C
lgtm
6 years, 4 months ago (2014-08-15 18:19:54 UTC) #4
whywhat
The CQ bit was checked by avayvod@chromium.org
6 years, 4 months ago (2014-08-15 18:20:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avayvod@chromium.org/479573002/1
6 years, 4 months ago (2014-08-15 18:23:10 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 19:57:21 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 20:21:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/6192)
6 years, 4 months ago (2014-08-15 20:21:38 UTC) #9
whywhat
The CQ bit was checked by avayvod@chromium.org
6 years, 4 months ago (2014-08-15 20:28:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avayvod@chromium.org/479573002/1
6 years, 4 months ago (2014-08-15 20:31:31 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 20:35:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (1) as 290003

Powered by Google App Engine
This is Rietveld 408576698