Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 479563007: Files.app: Remove MountedDiskMonitor. (Closed)

Created:
6 years, 3 months ago by hirono
Modified:
6 years, 3 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Files.app: Remove MountedDiskMonitor. The role of MountedDiskMonitor is replaced with DeviceEventRouter. BUG=360946, 396258 TEST=manually Committed: https://crrev.com/d85394fce83bd0acb07b84f7328a637f7d203d33 Cr-Commit-Position: refs/heads/master@{#292347}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -436 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/device_event_router.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/device_event_router.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/device_event_router_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
D chrome/browser/chromeos/file_manager/mounted_disk_monitor.h View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/chromeos/file_manager/mounted_disk_monitor.cc View 1 chunk +0 lines, -134 lines 0 comments Download
D chrome/browser/chromeos/file_manager/mounted_disk_monitor_unittest.cc View 1 chunk +0 lines, -139 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 21 chunks +22 lines, -47 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager_observer.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager_unittest.cc View 5 chunks +1 line, -9 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
hirono
hirono@chromium.org changed reviewers: + mtomasz@chromium.org
6 years, 3 months ago (2014-08-27 04:47:48 UTC) #1
hirono
PTAL the CL? Thank you!
6 years, 3 months ago (2014-08-27 04:47:48 UTC) #2
mtomasz
On 2014/08/27 04:47:48, hirono wrote: > PTAL the CL? Thank you! Can we also remove ...
6 years, 3 months ago (2014-08-27 06:21:46 UTC) #3
hirono
On 2014/08/27 06:21:46, mtomasz wrote: > On 2014/08/27 04:47:48, hirono wrote: > > PTAL the ...
6 years, 3 months ago (2014-08-27 10:13:27 UTC) #4
mtomasz
lgtm!
6 years, 3 months ago (2014-08-28 02:12:47 UTC) #5
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 3 months ago (2014-08-28 02:30:01 UTC) #6
hirono
On 2014/08/28 02:12:47, mtomasz wrote: > lgtm! Thanks!
6 years, 3 months ago (2014-08-28 02:30:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/479563007/20001
6 years, 3 months ago (2014-08-28 02:31:33 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 05:27:15 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 06:32:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/8823)
6 years, 3 months ago (2014-08-28 06:32:18 UTC) #11
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 3 months ago (2014-08-28 07:06:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/479563007/40001
6 years, 3 months ago (2014-08-28 07:07:58 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 87b0bb343a3125fb961543486d7cdd5f987ca07f
6 years, 3 months ago (2014-08-28 08:12:22 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:58:26 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d85394fce83bd0acb07b84f7328a637f7d203d33
Cr-Commit-Position: refs/heads/master@{#292347}

Powered by Google App Engine
This is Rietveld 408576698