Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 479553002: Modify SizeOfFirstPage to take ool constant pool into account. (Closed)

Created:
6 years, 4 months ago by rmcilroy
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Modify SizeOfFirstPage to take ool constant pool into account. The OOL constant pool places constants in the old pointer space rather than the code space which makes test-heap/ReleaseOverReservedPages fail. Modify SizeOfFirstPage to increase the initial size of old-pointer space by the size of the constant pool and decrease the code space by a corresponding amount. R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/heap/spaces.cc View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
Hannes, could you please take a look, thanks.
6 years, 4 months ago (2014-08-15 14:32:45 UTC) #1
Hannes Payer (out of office)
lgtm
6 years, 4 months ago (2014-08-18 11:36:09 UTC) #2
rmcilroy
6 years, 4 months ago (2014-08-20 14:40:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23241 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698