Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 47953004: telemetry: replace Google drive by image search in top_25 page set. (Closed)

Created:
7 years, 1 month ago by ernstm
Modified:
7 years, 1 month ago
Reviewers:
wiltzius, nduca, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

telemetry: replace Google drive by image search in top_25 page set. R=tonyg@chromium.org,nduca@chromium.org BUG=309953 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M tools/perf/page_sets/data/top_25.json View 3 chunks +5 lines, -2 lines 0 comments Download
A tools/perf/page_sets/data/top_25_002.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/top_25.json View 1 chunk +3 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ernstm
PTAL
7 years, 1 month ago (2013-11-04 20:49:00 UTC) #1
tonyg
lgtm But please wait for Tom to approve. Changing the URL set means old results ...
7 years, 1 month ago (2013-11-04 22:24:57 UTC) #2
ernstm
On 2013/11/04 22:24:57, tonyg wrote: > lgtm > > But please wait for Tom to ...
7 years, 1 month ago (2013-11-05 19:19:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/47953004/1
7 years, 1 month ago (2013-11-05 19:22:57 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219941
7 years, 1 month ago (2013-11-05 22:39:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/47953004/1
7 years, 1 month ago (2013-11-05 22:55:08 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94299
7 years, 1 month ago (2013-11-06 02:59:07 UTC) #7
tonyg
I recommend NOTRY=True on this patch. None of the tests depend on page sets currently.
7 years, 1 month ago (2013-11-06 03:14:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/47953004/1
7 years, 1 month ago (2013-11-06 04:53:09 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 05:16:14 UTC) #10
Message was sent while issue was closed.
Change committed as 233216

Powered by Google App Engine
This is Rietveld 408576698