Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 479513004: Prevent extension sideloading from Windows registry (Closed)

Created:
6 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
6 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Erik does not do reviews
Project:
chromium
Visibility:
Public.

Description

Track Windows registry-sideloaded extensions. This adds a creation flag for extensions which tracks if they were installed from a potentially untrusted source. The flag is currently set for extensions which are installed via the Windows registry from a CRX on the local filesystem. No enforcement action is being taken yet and no additional metrics are being collected. BUG=325469 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290122

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 1 comment Download
M chrome/browser/extensions/external_provider_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 1 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/extensions/external_registry_loader_win.cc View 1 2 5 chunks +13 lines, -4 lines 0 comments Download
M extensions/common/extension.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M extensions/common/extension.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (1 generated)
Ken Rockot(use gerrit already)
Here's the patch to prevent registry side-loading (of extensions only) from local filesystem paths. Not ...
6 years, 4 months ago (2014-08-15 17:48:18 UTC) #1
asargent_no_longer_on_chrome
If we're going to allow apps, we should probably allow themes also. Otherwise code changes ...
6 years, 4 months ago (2014-08-15 20:01:16 UTC) #2
Ken Rockot(use gerrit already)
On 2014/08/15 20:01:16, Antony Sargent wrote: > If we're going to allow apps, we should ...
6 years, 4 months ago (2014-08-15 23:25:10 UTC) #3
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 4 months ago (2014-08-15 23:25:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/479513004/60001
6 years, 4 months ago (2014-08-15 23:28:35 UTC) #5
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 4 months ago (2014-08-16 00:53:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/479513004/80001
6 years, 4 months ago (2014-08-16 00:55:39 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (80001) as 290122
6 years, 4 months ago (2014-08-16 07:58:11 UTC) #8
Evan Stade
6 years ago (2014-12-20 01:27:59 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/479513004/diff/80001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/479513004/diff/80001/chrome/app/generated_res...
chrome/app/generated_resources.grd:4560: +        Cannot install untrusted
extension with ID "<ph
name="IMPORT_ID">$1<ex>aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa</ex></ph>."
It seems this is not used anywhere. Can it be removed?

Powered by Google App Engine
This is Rietveld 408576698