Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: tools/presubmit.py

Issue 479503004: Add missing test directories to presubmit.py. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2012 the V8 project authors. All rights reserved. 3 # Copyright 2012 the V8 project authors. All rights reserved.
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 IGNORE_LINT = ['flag-definitions.h'] 232 IGNORE_LINT = ['flag-definitions.h']
233 233
234 def IgnoreFile(self, name): 234 def IgnoreFile(self, name):
235 return (super(CppLintProcessor, self).IgnoreFile(name) 235 return (super(CppLintProcessor, self).IgnoreFile(name)
236 or (name in CppLintProcessor.IGNORE_LINT)) 236 or (name in CppLintProcessor.IGNORE_LINT))
237 237
238 def GetPathsToSearch(self): 238 def GetPathsToSearch(self):
239 return ['src', 'include', 'samples', 239 return ['src', 'include', 'samples',
240 join('test', 'base-unittests'), 240 join('test', 'base-unittests'),
241 join('test', 'cctest'), 241 join('test', 'cctest'),
242 join('test', 'compiler-unittests')] 242 join('test', 'compiler-unittests'),
243 join('test', 'heap-unittests'),
244 join('test', 'runtime-unittests')]
243 245
244 def GetCpplintScript(self, prio_path): 246 def GetCpplintScript(self, prio_path):
245 for path in [prio_path] + os.environ["PATH"].split(os.pathsep): 247 for path in [prio_path] + os.environ["PATH"].split(os.pathsep):
246 path = path.strip('"') 248 path = path.strip('"')
247 cpplint = os.path.join(path, "cpplint.py") 249 cpplint = os.path.join(path, "cpplint.py")
248 if os.path.isfile(cpplint): 250 if os.path.isfile(cpplint):
249 return cpplint 251 return cpplint
250 252
251 return None 253 return None
252 254
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 success = CheckGeneratedRuntimeTests(workspace) and success 456 success = CheckGeneratedRuntimeTests(workspace) and success
455 success = CheckExternalReferenceRegistration(workspace) and success 457 success = CheckExternalReferenceRegistration(workspace) and success
456 if success: 458 if success:
457 return 0 459 return 0
458 else: 460 else:
459 return 1 461 return 1
460 462
461 463
462 if __name__ == '__main__': 464 if __name__ == '__main__':
463 sys.exit(Main()) 465 sys.exit(Main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698