Files.app: Not use URL in sorting

Files.app: Not use URL in sorting

In URL, some non-alphanumeric characters are represented as "%xx" format and it makes the sort incorrect. This patch creates the utility functions to sort and use them in sorting.

BUG=404061
TEST=manually tested

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289914

[yoshiki, 2014-08-15 05:32:09]

@fukino, PTAL. Thanks.

[fukino, 2014-08-15 05:58:14]

https://codereview.chromium.org/479503002/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/common/js/util.js (right):

https://codereview.chromium.org/479503002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/common/js/util.js:1025: return result;
Why doesn't this function return a value when the entry names are evaluated
equal?

https://codereview.chromium.org/479503002/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/directory_tree.js (right):

https://codereview.chromium.org/479503002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/directory_tree.js:515: // Don't need
to sort. The list is fixed order.
The list is fixed order, but without this sort, the order was changed.

Without this patch: My Drive | Shared with me | Recent | Offline.
With this patch: My Drive | Offline | Shared with me | Recent.

Is this OK?

[yoshiki, 2014-08-15 06:05:47]

@fukino, PTAL. Thanks.

https://codereview.chromium.org/479503002/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/common/js/util.js (right):

https://codereview.chromium.org/479503002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/common/js/util.js:1025: return result;
On 2014/08/15 05:58:14, fukino wrote:
> Why doesn't this function return a value when the entry names are evaluated
> equal?

Oh, sorry. Fixed.

https://codereview.chromium.org/479503002/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/directory_tree.js (right):

https://codereview.chromium.org/479503002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/directory_tree.js:515: // Don't need
to sort. The list is fixed order.
On 2014/08/15 05:58:14, fukino wrote:
> The list is fixed order, but without this sort, the order was changed.
> 
> Without this patch: My Drive | Shared with me | Recent | Offline.
> With this patch: My Drive | Offline | Shared with me | Recent.
> 
> Is this OK?

I didn't notice that. Thanks.

[fukino, 2014-08-15 06:08:00]

On 2014/08/15 06:05:47, yoshiki wrote:
> @fukino, PTAL. Thanks.
> 
>
https://codereview.chromium.org/479503002/diff/20001/ui/file_manager/file_man...
> File ui/file_manager/file_manager/common/js/util.js (right):
> 
>
https://codereview.chromium.org/479503002/diff/20001/ui/file_manager/file_man...
> ui/file_manager/file_manager/common/js/util.js:1025: return result;
> On 2014/08/15 05:58:14, fukino wrote:
> > Why doesn't this function return a value when the entry names are evaluated
> > equal?
> 
> Oh, sorry. Fixed.
> 
>
https://codereview.chromium.org/479503002/diff/20001/ui/file_manager/file_man...
> File ui/file_manager/file_manager/foreground/js/directory_tree.js (right):
> 
>
https://codereview.chromium.org/479503002/diff/20001/ui/file_manager/file_man...
> ui/file_manager/file_manager/foreground/js/directory_tree.js:515: // Don't
need
> to sort. The list is fixed order.
> On 2014/08/15 05:58:14, fukino wrote:
> > The list is fixed order, but without this sort, the order was changed.
> > 
> > Without this patch: My Drive | Shared with me | Recent | Offline.
> > With this patch: My Drive | Offline | Shared with me | Recent.
> > 
> > Is this OK?
> 
> I didn't notice that. Thanks.

lgtm. Thanks!

[yoshiki, 2014-08-15 06:08:12]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-08-15 06:10:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoshiki@chromium.org/479503002/40001

[commit-bot: I haz the power, 2014-08-15 16:34:43]

Committed patchset #3 (40001) as 289914